Add ERC: Common Quote Oracle #500
Conversation
|
✅ All reviewers have approved. |
eip-review-bot
changed the title
|
Oh great, now it seems to be stuck. Could I get some help here? |
fix: misc formatting and link fixes
ERCS/erc-7726.md
Outdated
| The following standard allows for the implementation of a standard API for data feeds providing the relative value of | ||
| assets in the Ethereum and EVM-compatible blockchains. |
There was a problem hiding this comment.
Your abstract does a good job introducing the goals of the proposal, but it lacks a high level (but still technical) overview of the content. A good abstract should have a good amount of detail on how the proposal accomplishes its goals.
There was a problem hiding this comment.
I included a bit more technical detail in the abstract. The ERC is very simple, so that limits what I can do.
There was a problem hiding this comment.
If necessary, I can add more content to the abstract from the Euler Whitepaper and my own article introductions, but that feels more like what I would do to an article than a technical abstract.
ERCS/erc-7726.md
Outdated
|
|
||
| For BTC, the address will be `0xbBbBBBBbbBBBbbbBbbBbbbbBBbBbbbbBbBbbBBbB`. | ||
|
|
||
| For assets without an address, but with an ISO 4217 code, the code will be used (e.g. `address(840)` for USD). |
There was a problem hiding this comment.
ISO standards are not usually free to access, and so we do not permit links to them. Please remove the reference.
There was a problem hiding this comment.
ISO 4217 in particular is free to use with many open source datasets for access since it's used widely
There was a problem hiding this comment.
ISO 4217 is explicitly free of charge.
The ISO 4217 currency codes have made it widely into the public domain, most notably as part of the chainlink contracts, but also on the wikipedia and other domains.
Co-authored-by: Sam Wilson <[email protected]>
Co-authored-by: Sam Wilson <[email protected]>
Co-authored-by: Sam Wilson <[email protected]>
Co-authored-by: Sam Wilson <[email protected]>
Co-authored-by: Sam Wilson <[email protected]>
|
@abcoathup, do you have any idea how to debug that jekyll job that is failing? There is not much between the commit that was working, and the commit where it started not to work. |
Co-authored-by: Sam Wilson <[email protected]>
Head branch was pushed to by a user without write access
For a while now a bunch of us have been toiling on what is now a minimal standard for oracle value feeds. This all probably started when I wrote this article about using value conversions instead of prices in smart contracts:
In very short, this is a minimal standard with a single function to get the value of an amount of an asset in terms of another asset. There are a number of adapters for current oracles from the community and from Euler.