Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update EIP-5453: Move to Review #6339

Closed
wants to merge 5 commits into from
Closed

Update EIP-5453: Move to Review #6339

wants to merge 5 commits into from

Conversation

xinbenlv
Copy link
Contributor

When opening a pull request to submit a new EIP, please use the suggested template: https://github.com/ethereum/EIPs/blob/master/eip-template.md

We have a GitHub bot that automatically merges some PRs. It will merge yours immediately if certain criteria are met:

  • The PR edits only existing draft PRs.
  • The build passes.
  • Your GitHub username or email address is listed in the 'author' header of all affected PRs, inside .
  • If matching on email address, the email address is the one publicly listed on your GitHub profile.

@xinbenlv xinbenlv requested a review from eth-bot as a code owner January 16, 2023 20:21
@github-actions github-actions bot added c-status Changes a proposal's status t-erc labels Jan 16, 2023
@eth-bot
Copy link
Collaborator

eth-bot commented Jan 16, 2023 •
edited
Loading

File EIPS/eip-5453.md

Requires 1 more reviewers from @axic, @Pandapip1, @SamWilsn

@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jan 16, 2023
@github-actions github-actions bot added the s-review This EIP is in Review label Jan 16, 2023
@github-actions github-actions bot added w-ci Waiting on CI to pass and removed w-ci Waiting on CI to pass labels Jan 16, 2023
@Pandapip1 Pandapip1 changed the title Move EIP-5453 to Review Update EIP-5453: Move to Review Jan 18, 2023
Pandapip1
Pandapip1 reviewed Jan 18, 2023
View reviewed changes
EIPS/eip-5453.md Outdated Show resolved Hide resolved
@github-actions github-actions bot removed the w-ci Waiting on CI to pass label Jan 18, 2023
Pandapip1
Pandapip1 suggested changes Jan 18, 2023
View reviewed changes
EIPS/eip-5453.md
@@ -14,7 +14,7 @@ requires: 165, 712, 1271, 5750
## Abstract

This EIP establish a general protocol for permitting approving function calls in the same transaction rely on [EIP-5750](./eip-5750.md).
Unlike a few prior art ([EIP-2612](./eip-2612.md) for [EIP-20](./eip-20.md), [EIP-4494](./eip-4494.md) for [EIP-721](./eip-721.md) that
Unlike a few prior art ([EIP-2612](./eip-2612.md) for [EIP-20](./eip-20.md), `EIP-4494` for [EIP-721](./eip-721.md) that
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Art? Why have you unlinked EIP-4494?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because EIP-4944 was still a DRAFT. the linter complains if we attempt to move EIP-5453 to REVIEW until 4944 is moved to REVIEW

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah. @SamWilsn is it okay to override the bot here?

Also, I still don't get what you mean by art.

Copy link
Contributor

@SamWilsn SamWilsn Mar 8, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SamWilsn is it okay to override the bot here?

I don't believe so. Just don't mention EIP-4494, or move it to the correct stage. If it's important enough to mention, it's important enough to make sure it doesn't change out from under you.

Also, I still don't get what you mean by art.

"Prior Art" is a legal term meaning related work that came before.

EIPS/eip-5453.md Outdated Show resolved Hide resolved
EIPS/eip-5453.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Jan 18, 2023
@poojaranjan poojaranjan mentioned this pull request Mar 7, 2023
Closed
25 tasks
@eth-bot eth-bot added the e-review Waiting on editor to review label Mar 8, 2023
@poojaranjan poojaranjan mentioned this pull request Apr 4, 2023
Closed
16 tasks
@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Jun 12, 2023
@xinbenlv
Copy link
Contributor Author

wip

@github-actions github-actions bot removed the w-stale Waiting on activity label Jun 13, 2023
@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Jun 27, 2023
@xinbenlv
Copy link
Contributor Author

WIP

@github-actions github-actions bot removed the w-stale Waiting on activity label Jun 28, 2023
@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Jul 12, 2023
@xinbenlv
Copy link
Contributor Author

WIP

@github-actions github-actions bot removed the w-stale Waiting on activity label Jul 13, 2023
@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Jul 28, 2023
@github-actions
Copy link

github-actions bot commented Sep 9, 2023

This pull request was closed due to inactivity. If you are still pursuing it, feel free to reopen it and respond to any feedback or request a review in a comment.

@github-actions github-actions bot closed this Sep 9, 2023
@xinbenlv
Copy link
Contributor Author

xinbenlv commented Sep 9, 2023

WIP

@Pandapip1 Pandapip1 reopened this Sep 9, 2023
@github-actions
Copy link

github-actions bot commented Sep 9, 2023

The commit 515a178 (as a parent of 2d1530b) contains errors.
Please inspect the Run Summary for details.

@github-actions github-actions bot removed the w-stale Waiting on activity label Sep 10, 2023
@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added w-stale Waiting on activity and removed w-stale Waiting on activity labels Sep 24, 2023
@github-actions
Copy link

There has been no activity on this pull request for 2 weeks. It will be closed after 3 months of inactivity. If you would like to move this PR forward, please respond to any outstanding feedback or add a comment indicating that you have addressed all required feedback and are ready for a review.

@github-actions github-actions bot added the w-stale Waiting on activity label Oct 10, 2023
@SamWilsn
Copy link
Contributor

I am closing this pull request because we are in the process of separating EIPs and ERCs into distinct repositories. Unfortunately, as far as we are aware, GitHub does not provide any tools to ease this migration, so every pull request will need to be re-opened manually.

As this is a PR to create / modify an ERC, I will kindly ask you to redirect this to the new repository at ethereum/ERCs. We have prepared a guide to help with the process.

If there is relevant history here, please link to this PR from the new pull request.

On behalf of the EIP Editors, I apologize for this inconvenience.

@SamWilsn SamWilsn closed this Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SamWilsn SamWilsn SamWilsn left review comments

@Pandapip1 Pandapip1 Pandapip1 requested changes

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot is a code owner

Assignees
No one assigned
Labels
c-status Changes a proposal's status e-review Waiting on editor to review s-review This EIP is in Review t-erc w-ci Waiting on CI to pass w-stale Waiting on activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xinbenlv @eth-bot @SamWilsn @Pandapip1