removing duplicate default bootnode #12534
Open
+0
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #12534 +/- ##
===========================================
- Coverage 65.04% 64.86% -0.18%
===========================================
Files 54 54
Lines 4460 4460
===========================================
- Hits 2901 2893 -8
- Misses 1382 1391 +9
+ Partials 177 176 -1
Flags with carried forward coverage won't be shown. Click here to find out more. |
ajsutton
reviewed
Oct 20, 2024
Comment on lines
-39
to
-40
| // Conduit | ||
| enode.MustParse("enode://9d7a3efefe442351217e73b3a593bcb8efffb55b4807699972145324eab5e6b382152f8d24f6301baebbfb5ecd4127bd3faab2842c04cd432bdf50ba092f6645@34.65.109.126:30305"), |
There was a problem hiding this comment.
Based on f054db0 I suspect we were actually trying to add a boot node from Conduit but failed to update the ENR. So we probably need to find out what the Conduit boot node actually is and update this rather than removing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the
DefaultBootnodes, we had two identical calls of:Tests
n/a
Additional context
A customer flagged this duplicate.