Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-supervisor: Cross safe updates cycle detection + tests #12530

Draft
wants to merge 8 commits into
base: cross-safe-updates
Choose a base branch
from

Conversation

tyler-smith
Copy link

No description provided.

@tyler-smith tyler-smith self-assigned this Oct 18, 2024
@tyler-smith tyler-smith marked this pull request as draft October 18, 2024 22:00
@tyler-smith tyler-smith changed the title Cross safe updates cycle detection + tests op-supervisor: Cross safe updates cycle detection + tests Oct 18, 2024
@axelKingsley
Copy link
Contributor

FYI, go-lint check is failing:

golangci-lint run -E goimports,sqlclosecheck,bodyclose,asciicheck,misspell,errorlint --timeout 5m -e "errors.As" -e "errors.Is" ./...
op-supervisor/supervisor/backend/cross/cycle.go:43:3: SA9003: empty branch (staticcheck)
                if err != nil {
                ^
make: *** [Makefile:23: lint-go] Error 1

Exited with code exit status 2

Copy link
Contributor

semgrep-app bot commented Oct 23, 2024

Semgrep found 1 sol-style-require-reason finding:

  • packages/contracts-bedrock/src/L2/SuperchainWETH.sol

require() must include a reason string

Ignore this finding from sol-style-require-reason.

Semgrep found 1 sol-style-notice-over-dev-natspec finding:

  • packages/contracts-bedrock/src/cannon/interfaces/IPreimageOracle.sol

Prefer @notice over @dev in natspec comments

Ignore this finding from sol-style-notice-over-dev-natspec.

Semgrep found 5 sol-style-input-arg-fmt findings:

Inputs to functions must be prepended with an underscore (_)

Ignore this finding from sol-style-input-arg-fmt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants