-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
batcher: batchSubmitter.checkExpectedProgress #12430
base: gk/batcher-node-progress
Are you sure you want to change the base?
Conversation
Semgrep found 1 TODO in error handling code Ignore this finding from err-todo. |
op-batcher/batcher/driver.go
Outdated
// TODO extract this into a config variable | ||
// TODO should we also wait numConfirmations (this is a txmgr config variable, not in scope of the batch submitter) | ||
|
||
BUFFER := uint64(1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a thought - given how this is used, I wonder whether naming itPROCESSING_WINDOW
would make it more intuitive?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 for choosing a better name. What do you think about just using VERIFIER_L1_CONFS
, which is the flag for the verifier?
optimism/op-node/flags/flags.go
Lines 206 to 212 in 466fd95
VerifierL1Confs = &cli.Uint64Flag{ | |
Name: "verifier.l1-confs", | |
Usage: "Number of L1 blocks to keep distance from the L1 head before deriving L2 data from. Reorgs are supported, but may be slow to perform.", | |
EnvVars: prefixEnvVars("VERIFIER_L1_CONFS"), | |
Value: 0, | |
Category: L1RPCCategory, | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yeah, that sounds great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Semgrep found 3
require() must include a reason string Ignore this finding from sol-style-require-reason.Semgrep found 6
Inputs to functions must be prepended with an underscore ( Semgrep found 4
No Semgrep found 1 Do not use Semgrep found 1 MarshalJSON with a pointer receiver has surprising results: golang/go#22967 Ignore this finding from marshal-json-pointer-receiver.Semgrep found 1 superfluous nil err check before return Ignore this finding from err-nil-check. |
towards #12124