Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to OP Mainnet runbook #997

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add links to OP Mainnet runbook #997

wants to merge 2 commits into from

Conversation

alfonso-op
Copy link

Adds links in the Node and Chain Operator tutorial indeces to our public OP Mainnet runbooks.

The links currently point to an internal Notion page and will need to be updated once the page is published.

@alfonso-op alfonso-op added the tutorial new tutorial request or revision to existing tutorial label Oct 16, 2024
@alfonso-op alfonso-op requested a review from a team as a code owner October 16, 2024 19:26
Copy link

netlify bot commented Oct 16, 2024

Deploy Preview for docs-optimism ready!

Name Link
🔨 Latest commit bb84159
🔍 Latest deploy log https://app.netlify.com/sites/docs-optimism/deploys/67179df7d9ffff0008caf3d2
😎 Deploy Preview https://deploy-preview-997--docs-optimism.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Contributor

coderabbitai bot commented Oct 16, 2024

Walkthrough

The pull request involves substantial updates to two documentation files focused on node operations and self-hosted chains. The document "How to Run a Node in the Superchain" has been revised to include detailed explanations of OP Stack rollup node architecture, configuration options, and monitoring setup. It also clarifies the prerequisites for running the node. Meanwhile, "How to Start a Self-Hosted Chain" has been enhanced with a new section directing users to OP Mainnet Runbooks for operational insights. These changes aim to improve clarity and usability of the guides.

Changes

File Path Change Summary
pages/builders/chain-operators/self-hosted.mdx Added a new section directing users to OP Mainnet Runbooks; minor content adjustments for clarity.
pages/builders/node-operators/rollup-node.mdx Expanded explanations on node architecture and configuration; clarified running instructions and monitoring setup; reformatted tutorial section into a table.

Possibly related issues

Possibly related PRs

  • 3 new node pages #679: This PR includes changes to the configuration settings for op-geth nodes, which are relevant to the main PR's updates on node configuration and setup.
  • revise node overview #694: This PR revises the node overview and includes a new file that provides a comprehensive guide on running an OP Stack rollup node, directly related to the main PR's focus on running a rollup node.
  • Deploy section #729: This PR adds a deployment section that includes configuration details for OP Stack blockchains, which aligns with the main PR's updates on node configuration and deployment processes.
  • Create chain-monitoring.mdx #764: This PR introduces a guide on monitoring options for OP Stack chains, which complements the main PR's updates on monitoring nodes.
  • Update Rollup Deployment Configuration #795: This PR updates the rollup deployment configuration documentation, which is directly related to the main PR's focus on configuring and running rollup nodes.
  • adding op-conductor documentation #818: This PR adds documentation for the op-conductor, which is relevant to the main PR's updates on node operation and management.
  • Update create-l2-rollup.mdx #824: This PR updates the create-l2-rollup tutorial, which is related to the main PR's focus on building and running nodes.
  • docs: Add rollup.sequencerhttp to node operation docs #865: This PR adds documentation regarding the --rollup.sequencerhttp flag, which is crucial for configuring nodes, aligning with the main PR's updates on node operation.
  • docs: fjord upgrade completed. #888: This PR updates the network upgrades documentation, which is relevant to the main PR's focus on node configuration and upgrades.
  • Add block numbers of network upgrades #912: This PR adds block numbers for network upgrades, which enhances the documentation related to node operations and configurations.
  • Fixed errors in RPC and typos in docs #1014: This PR focuses on fixing errors and typos in the documentation, which indirectly supports the clarity and usability of the main PR's updates.

Suggested labels

documentation

Suggested reviewers

  • sbvegan
  • bradleycamacho

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)
pages/builders/node-operators/rollup-node.mdx (1)

124-125: Approve addition of OP Mainnet Runbooks link with minor suggestions.

The addition of the link to OP Mainnet Runbooks aligns well with the PR objectives and provides valuable resources for node operators. Consider the following suggestions:

  1. Improve clarity by replacing "deeper insight" with a more specific phrase:
-For deeper insight into the day-to-day operations of OP Mainnet to see how these practices could apply to your own node operations, see the public [OP Mainnet Runbooks](https://www.notion.so/oplabs/Optimism-Runbooks-WIP-120f153ee1628045b230d5cd3df79f63?pvs=4).
+For detailed guidance on the day-to-day operations of OP Mainnet and how to apply these practices to your own node operations, refer to the public [OP Mainnet Runbooks](https://www.notion.so/oplabs/Optimism-Runbooks-WIP-120f153ee1628045b230d5cd3df79f63?pvs=4).
  1. Remember to update the link once the corresponding page is published, as mentioned in the PR objectives.
🧰 Tools
🪛 LanguageTool

[style] ~124-~124: Consider an alternative adjective to strengthen your wording.
Context: ...source code. | 🟡 Medium | For deeper insight into the day-to-day operations ...

(DEEP_PROFOUND)

pages/builders/chain-operators/self-hosted.mdx (1)

108-109: Consider rephrasing and using a more stable link format.

The new paragraph adds valuable context by referencing the OP Mainnet Runbooks. However, consider the following suggestions:

  1. Rephrase "deeper insight" to "more comprehensive insight" for stronger wording.
  2. Consider using a more stable link format instead of a direct Notion URL. This could be a redirect from the official documentation domain or a GitHub repository link, which would be more maintainable in the long term.

Here's a suggested revision:

Lastly, for more comprehensive insight into the day-to-day operations of OP Mainnet and how these operational practices could apply to your chain, see the public [OP Mainnet Runbooks](https://docs.optimism.io/operators/runbooks).

Note: Replace the example URL with the actual stable link to the runbooks.

🧰 Tools
🪛 LanguageTool

[style] ~108-~108: Consider an alternative adjective to strengthen your wording.
Context: ...'d love to grow this list! Lastly, for deeper insight into the day-to-day operations ...

(DEEP_PROFOUND)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between e08204f and ab32e3b.

📒 Files selected for processing (2)
  • pages/builders/chain-operators/self-hosted.mdx (1 hunks)
  • pages/builders/node-operators/rollup-node.mdx (1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
pages/builders/chain-operators/self-hosted.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for headers, buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • Use sentence case for H1, H2, and H3 headers, capitalizing only the first word and any proper nouns.
  • For all headers (H1, H2, H3), do not change the capitalization of proper nouns; keep them as they are.
    "
pages/builders/node-operators/rollup-node.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for headers, buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • Use sentence case for H1, H2, and H3 headers, capitalizing only the first word and any proper nouns.
  • For all headers (H1, H2, H3), do not change the capitalization of proper nouns; keep them as they are.
    "
🪛 LanguageTool
pages/builders/chain-operators/self-hosted.mdx

[style] ~108-~108: Consider an alternative adjective to strengthen your wording.
Context: ...'d love to grow this list! Lastly, for deeper insight into the day-to-day operations ...

(DEEP_PROFOUND)

pages/builders/node-operators/rollup-node.mdx

[style] ~124-~124: Consider an alternative adjective to strengthen your wording.
Context: ...source code. | 🟡 Medium | For deeper insight into the day-to-day operations ...

(DEEP_PROFOUND)

🔇 Additional comments (1)
pages/builders/chain-operators/self-hosted.mdx (1)

Line range hint 111-114: LGTM: New "Next Steps" section is informative and well-structured.

The new "Next Steps" section provides valuable guidance for users who have completed the main tutorial. It effectively directs readers to additional resources for common operations and troubleshooting. The content is clear, concise, and adheres to the provided coding guidelines.

🧰 Tools
🪛 LanguageTool

[style] ~108-~108: Consider an alternative adjective to strengthen your wording.
Context: ...'d love to grow this list! Lastly, for deeper insight into the day-to-day operations ...

(DEEP_PROFOUND)

@sbvegan sbvegan self-assigned this Oct 16, 2024
@bradleycamacho
Copy link
Member

bradleycamacho commented Oct 16, 2024

@sbvegan I see that you assigned yourself to this, but just wanted to jump in and say this seems like a problematic pattern to follow in the long term. I'd vote we look into migrating these into the monorepo at a minimum or the docs site if possible.

Seems fine to me in the short term, but I think this could easily cause maintenance issues over time.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
pages/builders/chain-operators/self-hosted.mdx (1)

108-109: Valuable addition, but consider placement and wording.

The addition of the OP Mainnet Runbooks link is a valuable resource for chain operators. However, consider the following suggestions:

  1. Move this content to a more appropriate section, such as after the "Launch Your Chain on Mainnet" section or create a new "Additional Resources" section. It doesn't directly relate to tutorials.

  2. Remember to update the link once the corresponding page is published, as mentioned in the PR objectives.

  3. Consider rephrasing the sentence to strengthen its impact:

- Lastly, for deeper insight into the day-to-day operations of OP Mainnet to see how these operational practices could apply to your chain, see the public [OP Mainnet Runbooks](https://oplabs.notion.site/OP-Mainnet-Runbooks-120f153ee1628045b230d5cd3df79f63).
+ For comprehensive insight into the day-to-day operations of OP Mainnet and to understand how these operational practices could apply to your chain, refer to the public [OP Mainnet Runbooks](https://oplabs.notion.site/OP-Mainnet-Runbooks-120f153ee1628045b230d5cd3df79f63).
🧰 Tools
🪛 LanguageTool

[style] ~108-~108: Consider an alternative adjective to strengthen your wording.
Context: ...'d love to grow this list! Lastly, for deeper insight into the day-to-day operations ...

(DEEP_PROFOUND)

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Files that changed from the base of the PR and between ab32e3b and bb84159.

📒 Files selected for processing (2)
  • pages/builders/chain-operators/self-hosted.mdx (1 hunks)
  • pages/builders/node-operators/rollup-node.mdx (1 hunks)
🧰 Additional context used
📓 Path-based instructions (2)
pages/builders/chain-operators/self-hosted.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for headers, buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • Use sentence case for H1, H2, and H3 headers, capitalizing only the first word and any proper nouns.
  • For all headers (H1, H2, H3), do not change the capitalization of proper nouns; keep them as they are.
    "
pages/builders/node-operators/rollup-node.mdx (1)

Pattern **/*.mdx: "ALWAYS review Markdown content THOROUGHLY with the following criteria:

  • Use proper nouns in place of personal pronouns like 'We' and 'Our' to maintain consistency in communal documentation.
  • Avoid gender-specific language and use the imperative form.
  • Monitor capitalization for emphasis. Avoid using all caps, italics, or bold for emphasis.
  • Ensure proper nouns are capitalized in sentences.
  • Apply the Oxford comma.
  • Use proper title case for headers, buttons, tab names, page names, and links. Sentence case should be used for body content and short phrases, even in links.
  • Use correct spelling and grammar at all times (IMPORTANT).
  • Use sentence case for H1, H2, and H3 headers, capitalizing only the first word and any proper nouns.
  • For all headers (H1, H2, H3), do not change the capitalization of proper nouns; keep them as they are.
    "
🪛 LanguageTool
pages/builders/chain-operators/self-hosted.mdx

[style] ~108-~108: Consider an alternative adjective to strengthen your wording.
Context: ...'d love to grow this list! Lastly, for deeper insight into the day-to-day operations ...

(DEEP_PROFOUND)

pages/builders/node-operators/rollup-node.mdx

[style] ~124-~124: Consider an alternative adjective to strengthen your wording.
Context: ...source code. | 🟡 Medium | For deeper insight into the day-to-day operations ...

(DEEP_PROFOUND)

🔇 Additional comments (2)
pages/builders/node-operators/rollup-node.mdx (2)

Line range hint 1-123: Well-structured and comprehensive guide.

The document provides a thorough and well-organized guide for running a node in the Superchain. The use of MDX components, clear section headers, and logical flow enhances readability and user experience. The content covers all essential aspects of node operation, making it a valuable resource for node operators.

🧰 Tools
🪛 LanguageTool

[style] ~124-~124: Consider an alternative adjective to strengthen your wording.
Context: ...source code. | 🟡 Medium | For deeper insight into the day-to-day operations ...

(DEEP_PROFOUND)


124-125: Valuable addition of OP Mainnet Runbooks reference.

The new paragraph provides a helpful link to the public OP Mainnet Runbooks, offering additional resources for node operators. This addition enhances the overall value of the guide.

Consider the following suggestions:

  1. For more impactful wording, consider replacing "deeper insight" with "comprehensive understanding" or "in-depth knowledge".
  2. The use of a Notion URL for the runbooks might pose maintenance challenges in the future. Consider migrating this content to a more stable platform or the documentation site itself for better long-term sustainability.

To verify the Notion URL and its potential impact, run the following script:

🧰 Tools
🪛 LanguageTool

[style] ~124-~124: Consider an alternative adjective to strengthen your wording.
Context: ...source code. | 🟡 Medium | For deeper insight into the day-to-day operations ...

(DEEP_PROFOUND)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge tutorial new tutorial request or revision to existing tutorial
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants