Modify rvgo/fast/yul64.go implementation to use yul256 implementation like slow / evm #131
+21
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mininny
force-pushed
the
feature/mininny/audit-25
branch
from
7b644b2 to
1517b1b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #131 +/- ##
==========================================
+ Coverage 61.63% 62.87% +1.23%
==========================================
Files 27 27
Lines 4147 4110 -37
==========================================
+ Hits 2556 2584 +28
+ Misses 1444 1385 -59
+ Partials 147 141 -6 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, a series of calculation functions on yul256.go - specifically add, div, sdiv, mod, smod, lt, gt, slt, sgt, eq, iszero, xor, sar are unused
However, these functions are meant to be used in the yul64.go, as slow and evm implementation has yul64 calculation functions inherited from the behavior from yul256 functions.