Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bpi interop/create bri1 msg example #713

Conversation

fleischr
Copy link
Contributor

@fleischr fleischr commented Jul 24, 2023

Description

Documents how to create the BPI Vendor Bank Verification use case on BRI-1 via Provide Shuttle, Postman, Node.js, and SAP ABAP

Related Issue

#695

Motivation and Context

Supports the BPI Interoperability showcase and roadshow

How Has This Been Tested

included in the readme provided

Screenshots (if appropriate)

included in the readme provided

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Request to be added as a Code Owner/Maintainer

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation. N/A
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I commit to abide by the Responsibilities of Code Owners/Maintainers.

Sorry, something went wrong.

@fleischr
Copy link
Contributor Author

Any feedback on this PR?

@Therecanbeonlyone1969
Copy link
Collaborator

Any feedback on this PR?

@fleischr we discussed that we need the example of NATS-to-NATS and not Client-NATS. So this PR needs to be updated accordingly, IMHO.

@Therecanbeonlyone1969
Copy link
Collaborator

@fleischr can you open a new PR with just NATS message json schemas please. Just the base schemas BRI-1 uses. We can work with that.

@fleischr
Copy link
Contributor Author

fleischr commented Sep 8, 2023

Also see provideplatform/axiom#96

@fleischr
Copy link
Contributor Author

fleischr commented Sep 8, 2023

DID-JWT related issue documented here provideplatform/ident#39

@ognjenkurtic
Copy link
Collaborator

@fleischr We ll reopen this one once the usage of did-jwt in BRI-1 has been settled.

@fleischr
Copy link
Contributor Author

fleischr commented Nov 4, 2023

@ognjenkurtic @Therecanbeonlyone1969 any other feedback on the PR otherwise? Are there any other details apart from did-jwt bring requested?

@Therecanbeonlyone1969
Copy link
Collaborator

@ognjenkurtic @Therecanbeonlyone1969 any other feedback on the PR otherwise? Are there any other details apart from did-jwt bring requested?

@fleischr besides the message schemas we discussed. No. Just did-jwt.

@fleischr
Copy link
Contributor Author

fleischr commented Nov 5, 2023

Could you add the did-jwt requirements here to #695 ? This will help me reopen the PR later as needed

@fleischr
Copy link
Contributor Author

fleischr commented Nov 6, 2023

@ognjenkurtic I would like you to give me a heads up next time you want to close one of my PRs without merging

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants