Cleaning up parametrize exit validation test

eth-educators · Apr 22, 2024 · e6f9dcb · e6f9dcb
1 parent 21ae5f0
commit e6f9dcb
Showing 1 changed file with 12 additions and 51 deletions.
diff --git a/tests/test_utils/test_validation.py b/tests/test_utils/test_validation.py
@@ -69,67 +69,28 @@ def test_normalize_input_list(input, result):
     "0x854053a7faebf4547ca3904ff14d896a994d5fb7289478681842fb72622364cd0cb4922170a370ea53234a734b47cd6"
     "80c7edca86e8d796abd8eaeb8dd85d99e57c962c84d6642dff4b6e9bfb6d6df5fa22910c583f13135f5b2b43e4f95e8cf"
 )
+invalid_pubkey = "b54186e3dbdde180cc39f52e0cf4207c5745a50e2e8bd12f49b925f87682cab88ef108f60cf3ea1ac82b7c6fe796f5d6"
+invalid_signature = (
+    "0x8cceb99d17361031e01dfb6aa997554a35f60bcc8a106ac76fdea6f5a4780fb8b65b4cd827bca0c88b340508b69f577"
+    "50122db94c319aa05a0165e71b41f30c0982c415727b7e2387cce78d995acd54f038b743dc1426b0fb0d4783617d4fe6e"
+)
 
 
 @pytest.mark.parametrize(
     'chain, epoch, validator_index, pubkey, signature, result',
     [
-        (
-            'mainnet',
-            0,
-            0,
-            valid_pubkey,
-            valid_signature,
-            True
-        ),
+        # valid
+        ('mainnet', 0, 0, valid_pubkey, valid_signature, True),
         # bad chain
-        (
-            'holesky',
-            0,
-            0,
-            valid_pubkey,
-            valid_signature,
-            False
-        ),
+        ('holesky', 0, 0, valid_pubkey, valid_signature, False),
         # bad epoch
-        (
-            'mainnet',
-            1,
-            0,
-            valid_pubkey,
-            valid_signature,
-            False
-        ),
+        ('mainnet', 1, 0, valid_pubkey, valid_signature, False),
         # bad validator_index
-        (
-            'mainnet',
-            0,
-            1,
-            valid_pubkey,
-            valid_signature,
-            False
-        ),
+        ('mainnet', 0, 1, valid_pubkey, valid_signature, False),
         # bad pubkey
-        (
-            'mainnet',
-            0,
-            0,
-            "b54186e3dbdde180cc39f52e0cf4207c5745a50e2e8bd12f49b925f87682cab88ef108f60cf3ea1ac82b7c6fe796f5d6",
-            valid_signature,
-            False
-        ),
+        ('mainnet', 0, 0, invalid_pubkey, valid_signature, False),
         # bad signature
-        (
-            'mainnet',
-            0,
-            0,
-            valid_pubkey,
-            (
-                "0x8cceb99d17361031e01dfb6aa997554a35f60bcc8a106ac76fdea6f5a4780fb8b65b4cd827bca0c88b340508b69f577"
-                "50122db94c319aa05a0165e71b41f30c0982c415727b7e2387cce78d995acd54f038b743dc1426b0fb0d4783617d4fe6e"
-            ),
-            False
-        ),
+        ('mainnet', 0, 0, valid_pubkey, invalid_signature, False),
     ]
 )
 def test_validate_signed_exit(chain, epoch, validator_index, pubkey, signature, result):