Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release/1.12 <- etc lite patch v1.12.2 #19

Draft
wants to merge 79 commits into
base: release/1.12
Choose a base branch
from

Conversation

meowsbits
Copy link

Only for 👀 on the diff.

s1na and others added 30 commits September 13, 2022 23:03
* graphql: fix tx logs

* minor

* Use optimized search for selecting tx logs
* graphql: fix tx logs

* graphql: refactor test service setup

* graphql: add test for tx logs
Date: 2022-10-27 09:16:05-07:00
Signed-off-by: meows <[email protected]>
…p155 impls; ETC forkid impl

Date: 2022-10-27 09:46:38-07:00
Signed-off-by: meows <[email protected]>
…hash pkg

Date: 2022-10-27 11:09:17-07:00
Signed-off-by: meows <[email protected]>
…classic flag/config and associated ethash inits

Date: 2022-10-27 11:36:34-07:00
Signed-off-by: meows <[email protected]>
Date: 2022-10-27 11:37:02-07:00
Signed-off-by: meows <[email protected]>
…sis hashes

Date: 2022-10-27 11:46:48-07:00
Signed-off-by: meows <[email protected]>
…/tests-etc)

Date: 2022-10-27 13:00:03-07:00
Signed-off-by: meows <[email protected]>
Date: 2022-10-27 13:13:45-07:00
Signed-off-by: meows <[email protected]>
Date: 2022-10-27 13:17:15-07:00
Signed-off-by: meows <[email protected]>
A few tests remain failing; apparently
all for chain id reasons; do the tests
have proper chain id values?
They should be 61 for ETC.

Date: 2022-10-27 15:57:50-07:00
Signed-off-by: meows <[email protected]>
Date: 2022-10-27 16:07:14-07:00
Signed-off-by: meows <[email protected]>
Date: 2022-10-28 09:23:37-07:00
Signed-off-by: meows <[email protected]>
Date: 2022-11-01 10:29:42-07:00
Signed-off-by: meows <[email protected]>
Date: 2022-11-01 10:31:31-07:00
Signed-off-by: meows <[email protected]>
…1.12)

When running the 'evm' command via retesteth,
a panic occurs and the trace has this dep at the
top of the pile.

This is a blind attempt to resolve the issue
by upgrading dependencies.

Date: 2022-11-01 10:38:40-07:00
Signed-off-by: meows <[email protected]>
Running retesteth with --t8ntool --filltests --j8
(or any --jX > 1) caused the suite to panic.

Geth/evm was panicing about here.
This fixes it.

It (the panic) looked like this...

goroutine 8 [chan receive]:
github.com/ethereum/go-ethereum/core.(*txSenderCacher).cache(0x0?)
        github.com/ethereum/go-ethereum/core/sender_cacher.go:63 +0x3b
created by github.com/ethereum/go-ethereum/core.newTxSenderCacher
        github.com/ethereum/go-ethereum/core/sender_cacher.go:55 +0x75

goroutine 9 [chan receive]:
github.com/ethereum/go-ethereum/core.(*txSenderCacher).cache(0x0?)
        github.com/ethereum/go-ethereum/core/sender_cacher.go:63 +0x3b
created by github.com/ethereum/go-ethereum/core.newTxSenderCacher
        github.com/ethereum/go-ethereum/core/sender_cacher.go:55 +0x75

goroutine 10 [chan receive]:
github.com/ethereum/go-ethereum/core.(*txSenderCacher).cache(0x0?)
        github.com/ethereum/go-ethereum/core/sender_cacher.go:63 +0x3b
created by github.com/ethereum/go-ethereum/core.newTxSenderCacher
        github.com/ethereum/go-ethereum/core/sender_cacher.go:55 +0x75

goroutine 11 [chan receive]:
github.com/ethereum/go-ethereum/core.(*txSenderCacher).cache(0x0?)
        github.com/ethereum/go-ethereum/core/sender_cacher.go:63 +0x3b
created by github.com/ethereum/go-ethereum/core.newTxSenderCacher
        github.com/ethereum/go-ethereum/core/sender_cacher.go:55 +0x75

Date: 2022-11-01 08:16:04-07:00
Signed-off-by: meows <[email protected]>
Conflicts:
      cmd/utils/flags.go
      core/genesis.go
      eth/backend.go
      eth/ethconfig/config.go
      go.sum
      params/config.go
      params/version.go
Date: 2022-11-01 10:54:44-07:00
Signed-off-by: meows <[email protected]>
…date

Date: 2022-12-12 09:50:18-08:00
Signed-off-by: meows <[email protected]>
Date: 2022-12-12 14:00:56-08:00
Signed-off-by: meows <[email protected]>
The big idea here is to move the necessary
configuration changes for ETC to patterns
that will also support ETC tests and testnets.

This meant removing global ETC-only parameters
and changing them to field-based values on
the Config struct type.

Most (?) tests -- except, notably, EOF tests --
are passing.

Date: 2022-12-12 16:46:18-08:00
Signed-off-by: meows <[email protected]>
EOF1 is not implemented in this codebase yet.
This commit should be reverted once EOF1 support
is merged.

Date: 2022-12-12 16:50:54-08:00
Signed-off-by: meows <[email protected]>
Conflicts:
      consensus/ethash/ethash.go
Conflicts:
      cmd/utils/flags.go
      core/forkid/forkid.go
      core/vm/interpreter.go
      eth/catalyst/api_test.go
      go.mod
      go.sum
      params/config.go
Date: 2023-02-08 09:22:10-08:00
Signed-off-by: meows <[email protected]>
Date: 2023-02-08 09:34:42-08:00
Signed-off-by: meows <[email protected]>
Date: 2023-08-30 08:23:48-06:00
Signed-off-by: meows <[email protected]>
Date: 2023-08-30 08:26:42-06:00
Signed-off-by: meows <[email protected]>
Date: 2023-08-30 08:27:41-06:00
Signed-off-by: meows <[email protected]>
Date: 2023-08-30 08:32:23-06:00
Signed-off-by: meows <[email protected]>
Date: 2023-08-30 08:32:32-06:00
Signed-off-by: meows <[email protected]>
Date: 2023-08-30 08:33:52-06:00
Signed-off-by: meows <[email protected]>
…Block

Date: 2023-08-30 08:36:52-06:00
Signed-off-by: meows <[email protected]>
TODO I've reinstalled these fields in the
miner config, but don't see what they actually
do. Even looking at historical code its not
apparent. So this may be a broken config, but
we'll see.

Date: 2023-08-30 08:55:32-06:00
Signed-off-by: meows <[email protected]>
…ngine

Date: 2023-08-30 08:58:41-06:00
Signed-off-by: meows <[email protected]>
Date: 2023-08-30 13:27:51-06:00
Signed-off-by: meows <[email protected]>
Date: 2023-08-30 13:30:55-06:00
Signed-off-by: meows <[email protected]>
Date: 2023-08-30 13:36:30-06:00
Signed-off-by: meows <[email protected]>
…has no field or method AddLocals) (typecheck)

Date: 2023-08-30 13:52:25-06:00
Signed-off-by: meows <[email protected]>
…/go-ethereum/core/types.Transaction) as []*txpool.Transaction value in argument to backend.txPool.Add

Date: 2023-08-31 06:04:45-06:00
Signed-off-by: meows <[email protected]>
This fixes the failing tests at TestHeaderVerification

Date: 2023-08-31 06:45:22-06:00
Signed-off-by: meows <[email protected]>
This fixes the failing TestGethClient which
was complaining about invalid mix digest.

Date: 2023-08-31 07:11:41-06:00
Signed-off-by: meows <[email protected]>
Fixes failing TestEthClient

Date: 2023-08-31 07:20:00-06:00
Signed-off-by: meows <[email protected]>
Fixes failing TestGraphQLBlockSerialization

Date: 2023-08-31 07:25:41-06:00
Signed-off-by: meows <[email protected]>
Date: 2023-08-31 07:31:59-06:00
Signed-off-by: meows <[email protected]>
This fixes TestStreamUncleBlock which a new test.
Still failing are two tests, both RegenerateMiningBlock...

Date: 2023-08-31 08:15:18-06:00
Signed-off-by: meows <[email protected]>
These tests (ethash and clique) were both
failing because the third and last event
were not received; apparently the txpool.Add
was supposed to trigger that at one point.
But anymore they don't trigger the event,
and I'm not even sure how they were to
have done so.
Upstream ethereum/go-ethereum at v1.12.2
DOES NOT have these tests (they were unique
to this branch), so I'm just going to remove them
since we're trying to stay close to upstream
anyways.

Date: 2023-08-31 09:11:41-06:00
Signed-off-by: meows <[email protected]>
@meowsbits meowsbits changed the base branch from master to release/1.12 September 1, 2023 12:58
@meowsbits meowsbits changed the title master <- etc lite patch v1.12.2 release/1.12 <- etc lite patch v1.12.2 Sep 1, 2023
Date: 2023-09-01 07:00:50-06:00
Signed-off-by: meows <[email protected]>
Install miner flags again -- noverify and notify
values are passed to the remote sealer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants