Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows: fixing c++/cmake issues w/r/t evmone, evmc tests #508

Closed
wants to merge 3 commits into from

Conversation

meowsbits
Copy link
Member

The command 'make test-evmc' complains about a GLIBCXX version incompatibility (missing 3.4.29).

This issue has been shown resolved by the Actions CI run here: https://github.com/meowsbits/core-geth/actions/runs/3429882085/jobs/5716103415 The run ultimately fails, but it fails because the tests fail, while the evmone .so is used appropriately.

Full context of the error follows.

panic: EVMC loading error: /lib/x86_64-linux-gnu/libstdc++.so.6: version GLIBCXX_3.4.29 not found, required by /home/ia/go/src/github.com/ethereum/go-ethereum/build/_workspace/evmone/lib/libevmone.so

 goroutine 1 [running]:
 github.com/ethereum/go-ethereum/core/vm.initEVMC(0x11e4e0?, {0x7ffc235f574c?, 0xc0001361c0?})
       /home/ia/go/src/github.com/ethereum/go-ethereum/core/vm/evmc.go:83 +0x605
 github.com/ethereum/go-ethereum/core/vm.InitEVMCEVM({0x7ffc235f574c, 0x58})
       /home/ia/go/src/github.com/ethereum/go-ethereum/core/vm/evmc.go:60 +0xd0
 github.com/ethereum/go-ethereum/tests.TestMain(0xffffffffffffffff?)
       /home/ia/go/src/github.com/ethereum/go-ethereum/tests/init_test.go:50 +0xec
 main.main()
       _testmain.go:77 +0x1d3
 FAIL  github.com/ethereum/go-ethereum/tests   0.014s
 FAIL
 make: *** [Makefile:57: test-evmc] Error 1

See also here: https://github.com/etclabscore/core-geth/actions/runs/3414467176/jobs/5682462570#step:5:482

Date: 2022-11-09 07:44:38-08:00
Signed-off-by: meows [email protected]

The command 'make test-evmc' complains about a GLIBCXX version
incompatibility (missing 3.4.29).

This issue has been shown resolved by the Actions CI run here:
https://github.com/meowsbits/core-geth/actions/runs/3429882085/jobs/5716103415
The run ultimately fails, but it fails because the tests fail,
while the evmone .so is used appropriately.

Full context of the error follows.

panic: EVMC loading error: /lib/x86_64-linux-gnu/libstdc++.so.6: version GLIBCXX_3.4.29 not found, required by /home/ia/go/src/github.com/ethereum/go-ethereum/build/_workspace/evmone/lib/libevmone.so

 goroutine 1 [running]:
 github.com/ethereum/go-ethereum/core/vm.initEVMC(0x11e4e0?, {0x7ffc235f574c?, 0xc0001361c0?})
       /home/ia/go/src/github.com/ethereum/go-ethereum/core/vm/evmc.go:83 +0x605
 github.com/ethereum/go-ethereum/core/vm.InitEVMCEVM({0x7ffc235f574c, 0x58})
       /home/ia/go/src/github.com/ethereum/go-ethereum/core/vm/evmc.go:60 +0xd0
 github.com/ethereum/go-ethereum/tests.TestMain(0xffffffffffffffff?)
       /home/ia/go/src/github.com/ethereum/go-ethereum/tests/init_test.go:50 +0xec
 main.main()
       _testmain.go:77 +0x1d3
 FAIL  github.com/ethereum/go-ethereum/tests   0.014s
 FAIL
 make: *** [Makefile:57: test-evmc] Error 1

See also here: https://github.com/etclabscore/core-geth/actions/runs/3414467176/jobs/5682462570#step:5:482

Date: 2022-11-09 07:44:38-08:00
Signed-off-by: meows <[email protected]>
Copy link
Member

@ziogaschr ziogaschr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How the empty cmake.sh is being used?

.github/workflows/evmc.yml Outdated Show resolved Hide resolved
@meowsbits
Copy link
Member Author

cmake.sh was an accident, leftover from trying to get cmake installed and c++ adequately available for evmone. Removed now with 1eec2d8.

@meowsbits
Copy link
Member Author

The cmake build/CI issue has been resolved.

I'm going to close this PR since I've been continuing development on the EVMC integration, and will merge my development changes to the evmc-v10 branch and PR (#507).

@meowsbits meowsbits closed this Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants