Change experimental-memory-mlock flag to memory-mlock

[jmao-dd]

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

This is for #19061

[k8s-ci-robot]

Hi @jmao-dd. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[jmao-dd]

After reading through the comments on #19124 I realized we don't want to migrate this flag to feature gate any more. I will change the PR to accept both --experimental-memory-mlock and --memory-mlock.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.80%. Comparing base (532c601) to head (73c37b3).

Additional details and impacted files

Files with missing lines	Coverage Δ
server/config/config.go	80.23% <ø> (ø)
server/embed/config.go	79.65% <100.00%> (+0.06%)	⬆️
server/embed/etcd.go	76.49% <100.00%> (ø)
server/etcdmain/config.go	73.17% <100.00%> (+0.33%)	⬆️
server/storage/backend.go	72.72% <100.00%> (ø)

... and 26 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19273      +/-   ##
==========================================
- Coverage   68.87%   68.80%   -0.07%     
==========================================
  Files         420      420              
  Lines       35680    35684       +4     
==========================================
- Hits        24573    24554      -19     
- Misses       9685     9704      +19     
- Partials     1422     1426       +4     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 532c601...73c37b3. Read the comment docs.

[ahrtr]

I don't think this PR is correct, please follow the same pattern as #19267

[jmao-dd]

I don't think this PR is correct, please follow the same pattern as #19267

Got it. Will update.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jmao-dd
Once this PR has been reviewed and has the lgtm label, please assign spzala for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jmao-dd]

The history of this PR is too complex to squash into one commit so I created a new PR #19277