Remove the code of checking ClusterVersionSet in MinimalEtcdVersion

[ahrtr]

Link to #19168

[ahrtr]

The test failures are expected. I will fix them later.

@serathius PTAL

[ahrtr]

cc @fuweid @siyuanfoundation

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.86%. Comparing base (e289ba3) to head (3e5e79d).
Report is 2 commits behind head on main.

Additional details and impacted files

Files with missing lines	Coverage Δ
server/storage/wal/version.go	51.92% <ø> (+0.38%)	⬆️

... and 15 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19263      +/-   ##
==========================================
+ Coverage   68.84%   68.86%   +0.02%     
==========================================
  Files         420      420              
  Lines       35681    35674       -7     
==========================================
+ Hits        24563    24566       +3     
+ Misses       9689     9686       -3     
+ Partials     1429     1422       -7     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e289ba3...3e5e79d. Read the comment docs.

[siyuanfoundation]

This would probably not impact 3.6->3.5. But for 3.7->3.6 downgrade with offline migration, if there is an entry of ClusterVersionSet to be applied after the downgrade, would that mean the cluster version be set to 3.7 when the old ClusterVersionSet entry is applied?

[ahrtr]

This would probably not impact 3.6->3.5.

This PR resolves the offline migration (3.6 -> 3.5) issue as mentioned in #19168 (comment).

would that mean the cluster version be set to 3.7 when the old ClusterVersionSet entry is applied?

Nope. The change in this PR only means the minimum etcd version to understand ClusterVersionSet is 3.5.

cc @serathius PTAL in case you have any further comment.

[ahrtr]

@serathius PTAL, thx

[ahrtr]

/test pull-etcd-integration-1-cpu-arm64

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, fuweid, serathius, siyuanfoundation

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahrtr,serathius]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment