Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance test case TestEtctlutlMigrate to support multiple member cluster #19174

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Jan 11, 2025

This PR is extracted from #19168

cc @fuweid @serathius @ivanvc @jmhbnz @siyuanfoundation

Copy link

codecov bot commented Jan 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.73%. Comparing base (9db8dcb) to head (c2025cb).
Report is 13 commits behind head on main.

Additional details and impacted files

see 25 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19174      +/-   ##
==========================================
- Coverage   68.87%   68.73%   -0.15%     
==========================================
  Files         420      420              
  Lines       35649    35649              
==========================================
- Hits        24554    24503      -51     
- Misses       9674     9718      +44     
- Partials     1421     1428       +7     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9db8dcb...c2025cb. Read the comment docs.

@serathius
Copy link
Member

What's the benefit of running command on 3 member cluster if we just run it 3 times and never start the cluster?

@ahrtr
Copy link
Member Author

ahrtr commented Jan 13, 2025

What's the benefit of running command on 3 member cluster if we just run it 3 times and never start the cluster?

It will be useful to the following PR. It's just to make reviewing the following PR easier.

I will try to start the members again after the migrating. For example, after we migrate from 3.6 to 3.5, we should be able to start the members with 3.5 binary.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit ad11af7 into etcd-io:main Jan 13, 2025
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants