[2025-01-10] Bump dependency updates identified by dependabot

[henrybear327]

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

This pull request completes this week's etcd dependency updates following our dependency roster and dependency management instructions.

Summary of actions

Bumped

• build(deps): bump github.com/golangci/golangci-lint from 1.62.2 to 1.63.4 in /tools/mod #19134
• build(deps): bump golang.org/x/net from 0.33.0 to 0.34.0 #19133
• build(deps): bump golang.org/x/sys from 0.28.0 to 0.29.0 #19132
• build(deps): bump github.com/jonboulle/clockwork from 0.4.0 to 0.5.0 #19131
• build(deps): bump golang.org/x/crypto from 0.31.0 to 0.32.0 #19130
• build(deps): bump golang.org/x/time from 0.8.0 to 0.9.0 #19129

Fully indirect

None

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.82%. Comparing base (9db8dcb) to head (1430c1d).
Report is 11 commits behind head on main.

Additional details and impacted files

see 21 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #19165      +/-   ##
==========================================
- Coverage   68.87%   68.82%   -0.06%     
==========================================
  Files         420      420              
  Lines       35649    35649              
==========================================
- Hits        24554    24534      -20     
- Misses       9674     9695      +21     
+ Partials     1421     1420       -1     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9db8dcb...1430c1d. Read the comment docs.

[henrybear327]

Bumping #19131 requires a fix to the current codebase, please see https://github.com/etcd-io/etcd/pull/19165/files#diff-cb0b9576444c99c569b72d696a412440f4a8da4ae514ac19eae631007ffc6863R353

(Sorry that this took longer to resolve than expected as I took the wrong long way when debugging the tests...)

[henrybear327]

/retest

[jmhbnz]

LGTM - Thanks @henrybear327

Fix for fakeclock looks good based on the upstream guidance in jonboulle/clockwork@b120971

Convert FakeClock to a struct.
This change ensures future modifications to FakeClock will not break users.

Unfortunately, this change does break current users who use FakeClock as an argument, return value, or embed it in a struct or interface. With limtied exception, build errors can be fixed by running:

$ grep -rl 'clockwork.FakeClock' /path/to/code_base | \
    xargs sed -i 's/clockwork.FakeClock/*clockwork.FakeClock/g'

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, henrybear327, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahrtr,jmhbnz]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment