Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] manual: Fix risk of a partial write txn being applied #18799

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

shyamjvs
Copy link
Contributor

Manually backported #18749 given conflicting changes.

/assign @ahrtr

@k8s-ci-robot
Copy link

Hi @shyamjvs. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ahrtr
Copy link
Member

ahrtr commented Oct 28, 2024

/ok-to-test

Thanks @shyamjvs

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

The workflows on arm64 are blocked because we don't have arm64 runners. Once the workflows are migrated to prow, we will remove arm64 workflow on github.

@ivanvc
Copy link
Member

ivanvc commented Oct 29, 2024

/test all

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, serathius, shyamjvs

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 23f887a into etcd-io:release-3.5 Oct 29, 2024
27 of 32 checks passed
@shyamjvs shyamjvs deleted the backport-3.5 branch October 29, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants