Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump go version to 1.23.2 #18666

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Bump go version to 1.23.2 #18666

merged 1 commit into from
Oct 2, 2024

Conversation

PyAgni
Copy link
Contributor

@PyAgni PyAgni commented Oct 1, 2024

@k8s-ci-robot
Copy link

Hi @PyAgni. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivanvc
Copy link
Member

ivanvc commented Oct 1, 2024

/ok-to-test

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.83%. Comparing base (2c97110) to head (dbf1a5e).

Current head dbf1a5e differs from pull request most recent head 8650df2

Please upload reports for the commit 8650df2 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 25 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18666      +/-   ##
==========================================
+ Coverage   68.70%   68.83%   +0.13%     
==========================================
  Files         420      420              
  Lines       35535    35535              
==========================================
+ Hits        24414    24462      +48     
+ Misses       9686     9645      -41     
+ Partials     1435     1428       -7     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2c97110...8650df2. Read the comment docs.

@ivanvc
Copy link
Member

ivanvc commented Oct 2, 2024

/retest

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Agni.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, PyAgni

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 4e9ed2c into etcd-io:main Oct 2, 2024
38 checks passed
@ivanvc ivanvc mentioned this pull request Oct 2, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants