-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Bump go toolchain to 1.23.1 #18644
Conversation
Reference: - https://github.com/etcd-io/etcd/issues/18543 - kubernetes/release#3650 Signed-off-by: Chun-Hung Tseng <[email protected]>
6369020
to
dcdfead
Compare
/retest |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 21 files with indirect coverage changes @@ Coverage Diff @@
## main #18644 +/- ##
==========================================
- Coverage 68.77% 68.73% -0.04%
==========================================
Files 420 420
Lines 35535 35535
==========================================
- Hits 24438 24426 -12
- Misses 9668 9673 +5
- Partials 1429 1436 +7 Continue to review full report in Codecov by Sentry.
|
/retest |
1 similar comment
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, Henry. By the way, it looks like there were a lot of test flakes 😟.
Yeah, I wasn't sure if it's just tonight because my other 2 PRs also are flaky :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @henrybear327
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, henrybear327, ivanvc, jmhbnz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reference:
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.