-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2024-09-25] Bump dependency updates identified by dependabot #18636
Conversation
7c8c958
to
aaf8313
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 15 files with indirect coverage changes @@ Coverage Diff @@
## main #18636 +/- ##
==========================================
- Coverage 68.74% 68.68% -0.06%
==========================================
Files 420 420
Lines 35535 35535
==========================================
- Hits 24427 24407 -20
- Misses 9677 9696 +19
- Partials 1431 1432 +1 Continue to review full report in Codecov by Sentry.
|
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, Henry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @henrybear327 - A couple minor tweaks then this will be looking good to me.
….20.4 Reference: - etcd-io#18631 Signed-off-by: Chun-Hung Tseng <[email protected]>
Reference: - etcd-io#18628 Signed-off-by: Chun-Hung Tseng <[email protected]>
f82c522
to
cb5bd6c
Compare
cb5bd6c
to
c88fe2c
Compare
In summary, the bump is performed for the following dependencies: - go.opentelemetry.io/otel/exporters/otlp/otlptrace from v1.29.0 to v1.30.0 - go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc from v1.29.0 to v1.30.0 - go.opentelemetry.io/otel/metric from v1.29.0 to v1.30.0 - go.opentelemetry.io/otel/sdk from v1.29.0 to v1.30.0 - go.opentelemetry.io/otel/trace from v1.29.0 to v1.30.0 This commit also addressed the following issues FAIL: inconsistent versions for dependency: google.golang.org/genproto/googleapis/api - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/client/v3 - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/etcdctl/v3 - google.golang.org/genproto/googleapis/[email protected] from: go.etcd.io/etcd/api/v3 - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/etcdutl/v3 - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/tests/v3 - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/tools/v3 - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/v3 - google.golang.org/genproto/googleapis/[email protected] from: go.etcd.io/etcd/server/v3 - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/tools/v3 FAIL: inconsistent versions for dependency: google.golang.org/genproto/googleapis/rpc - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/api/v3 - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/client/v3 - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/etcdctl/v3 - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/pkg/v3 - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/tools/testgrid-analysis/v3 - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/etcdutl/v3 - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/server/v3 - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/tests/v3 - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/tools/v3 - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/v3 - google.golang.org/genproto/googleapis/[email protected] (indirect) from: go.etcd.io/etcd/tools/v3 FAIL: inconsistent dependencies Reference: - etcd-io#18629 - etcd-io#18630 - etcd-io#18626 - etcd-io#18627 Signed-off-by: Chun-Hung Tseng <[email protected]>
c88fe2c
to
79f31c7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @henrybear327
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, Henry.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, henrybear327, ivanvc, jmhbnz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.
This pull request completes this week's etcd dependency updates following our dependency roster and dependency management instructions.
Summary of actions
Bumped
Fully indirect
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.