-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github: remove build job #18633
github: remove build job #18633
Conversation
This job was migrated to the prow infrastructure in May (kubernetes/test-infra#32672). Deleting the GitHub workflow to remove duplicate jobs should be fine. Signed-off-by: Ivan Valdes <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 11 files with indirect coverage changes @@ Coverage Diff @@
## main #18633 +/- ##
==========================================
+ Coverage 68.75% 68.79% +0.03%
==========================================
Files 420 420
Lines 35522 35522
==========================================
+ Hits 24423 24436 +13
+ Misses 9677 9663 -14
- Partials 1422 1423 +1 Continue to review full report in Codecov by Sentry.
|
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - https://testgrid.k8s.io/sig-etcd-presubmits#pull-etcd-build is behaving nicely, thanks @ivanvc
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc, jmhbnz, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This job was migrated to the prow infrastructure in May (kubernetes/test-infra#32672). Deleting the GitHub workflow to remove duplicate jobs should be fine.
Part of kubernetes/test-infra#32754, kubernetes/k8s.io#6102.
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.