Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: remove build job #18633

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

ivanvc
Copy link
Member

@ivanvc ivanvc commented Sep 23, 2024

This job was migrated to the prow infrastructure in May (kubernetes/test-infra#32672). Deleting the GitHub workflow to remove duplicate jobs should be fine.

Part of kubernetes/test-infra#32754, kubernetes/k8s.io#6102.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

This job was migrated to the prow infrastructure in May
(kubernetes/test-infra#32672). Deleting the
GitHub workflow to remove duplicate jobs should be fine.

Signed-off-by: Ivan Valdes <[email protected]>
@k8s-ci-robot k8s-ci-robot added github_actions Pull requests that update GitHub Actions code size/M labels Sep 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 23, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.79%. Comparing base (bd93a00) to head (b5e68d8).
Report is 14 commits behind head on main.

Current head b5e68d8 differs from pull request most recent head 3347d98

Please upload reports for the commit 3347d98 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 11 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18633      +/-   ##
==========================================
+ Coverage   68.75%   68.79%   +0.03%     
==========================================
  Files         420      420              
  Lines       35522    35522              
==========================================
+ Hits        24423    24436      +13     
+ Misses       9677     9663      -14     
- Partials     1422     1423       +1     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd93a00...3347d98. Read the comment docs.

@ivanvc
Copy link
Member Author

ivanvc commented Sep 23, 2024

/retest

Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, jmhbnz, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [ahrtr,jmhbnz,serathius]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit acb1b17 into etcd-io:main Sep 24, 2024
36 checks passed
@ivanvc ivanvc deleted the remove-build-github-workflows branch September 24, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved github_actions Pull requests that update GitHub Actions code size/M
Development

Successfully merging this pull request may close these issues.

6 participants