update: cobra.ExactValidArgs method is deprecated

[Kamandlou]

cobra.ExactValidArgs method is deprecated I update cobra.ExactValidArgs method to cobra.MatchAll method

[k8s-ci-robot]

Hi @Kamandlou. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Kamandlou]

and alose use errors.Is for error equality checks

[ivanvc]

/ok-to-test

Hi @Kamandlou, thanks for your pull request. Regarding the changes to use errors.Is(), they may overlap with #18615 (part of #18576). To avoid conflicts, could you please limit your PR to include only the change to cobra.MatchAll()?

Thanks again, Amir!

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 61.90476% with 8 lines in your changes missing coverage. Please review.

Project coverage is 68.82%. Comparing base (2ed418c) to head (dd0fcd2).
Report is 20 commits behind head on main.

❗ Current head dd0fcd2 differs from pull request most recent head 063627e

Please upload reports for the commit 063627e to get more accurate results.

Files with missing lines	Patch %	Lines
server/etcdserver/api/v3discovery/discovery.go	0.00%	1 Missing and 1 partial ⚠️
server/etcdserver/server.go	66.66%	2 Missing ⚠️
etcdctl/ctlv3/command/completion_command.go	0.00%	1 Missing ⚠️
etcdutl/etcdutl/completion_commmand.go	0.00%	1 Missing ⚠️
pkg/proxy/server.go	50.00%	1 Missing ⚠️
server/etcdserver/v3_server.go	87.50%	0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Files with missing lines	Coverage Δ
server/etcdserver/api/v3compactor/periodic.go	90.24% <100.00%> (ø)
etcdctl/ctlv3/command/completion_command.go	0.00% <0.00%> (ø)
etcdutl/etcdutl/completion_commmand.go	0.00% <0.00%> (ø)
pkg/proxy/server.go	60.95% <50.00%> (+0.33%)	⬆️
server/etcdserver/v3_server.go	72.57% <87.50%> (-1.32%)	⬇️
server/etcdserver/api/v3discovery/discovery.go	67.80% <0.00%> (ø)
server/etcdserver/server.go	81.34% <66.66%> (+0.44%)	⬆️

... and 21 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18612      +/-   ##
==========================================
- Coverage   68.83%   68.82%   -0.01%     
==========================================
  Files         420      420              
  Lines       35474    35522      +48     
==========================================
+ Hits        24418    24448      +30     
- Misses       9636     9650      +14     
- Partials     1420     1424       +4     

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ed418c...063627e. Read the comment docs.

[Kamandlou]

/ok-to-test

Hi @Kamandlou, thanks for your pull request. Regarding the changes to use errors.Is(), they may overlap with #18615 (part of #18576). To avoid conflicts, could you please limit your PR to include only the change to cobra.MatchAll()?

Thanks again, Amir!

Hi @ivanvc, Done :))

[jmhbnz]

Thanks for addressing this deprecation @Kamandlou. Can you please squash your commits in preparation for merge. Thanks!

[Kamandlou]

Thanks for addressing this deprecation @Kamandlou. Can you please squash your commits in preparation for merge. Thanks!

@jmhbnz Done.

[ivanvc]

/retest

[ivanvc]

Hi @Kamandlou, I just realized there is another instance in https://github.com/etcd-io/etcd/blob/main/etcdutl%2Fetcdutl%2Fcompletion_commmand.go. Could you please update it too (and squash commits)? Or, it's fine to do it in a follow-up otherwise. Thanks!

[Kamandlou]

Hi @ivanvc
This PR is ready to merge.

[ivanvc]

LGTM. Thanks, Amir.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, Kamandlou

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [ahrtr]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment