Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tools/mod to module_dirs #18590

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Add tools/mod to module_dirs #18590

merged 1 commit into from
Sep 19, 2024

Commits on Sep 18, 2024

  1. Add tools/mod to module_dirs

    As `tools/mod` also contains the `go.mod` file. We should add it to the
    `module_dirs` variable, so that when executing `./scripts/fix.sh`, the
    proper checks and fixes can be applied.
    
    To address the issue of broken unit tests and code coverage due to the
    directory's lack of Go code, we've introduced a new doc.go file. This
    file acts as a placeholder, enabling tools like golangci-lint and
    go test to function correctly.
    
    ---
    
    Discovered when working on etcd-io#18575
    
    The directories are checked against the following:
    - Command: `find . -type f -name go.mod -exec dirname {} \;`
    - Output:
    ```
    ./etcdutl
    .
    ./tools/testgrid-analysis
    ./tools/rw-heatmaps
    ./tools/mod
    ./etcdctl
    ./tests
    ./server
    ./api
    ./client/internal/v2
    ./client/v3
    ./client/pkg
    ./pkg
    ```
    
    Signed-off-by: Chun-Hung Tseng <[email protected]>
    henrybear327 committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    fc901bd View commit details
    Browse the repository at this point in the history