tests: fix TestV2DeprecationSnapshotMatches #18583
Conversation
Signed-off-by: Clement <[email protected]>
|
Hi @clement2026. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
clement2026
changed the title
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 22 files with indirect coverage changes @@ Coverage Diff @@
## main #18583 +/- ##
==========================================
+ Coverage 68.73% 68.77% +0.04%
==========================================
Files 420 420
Lines 35474 35474
==========================================
+ Hits 24382 24399 +17
+ Misses 9666 9648 -18
- Partials 1426 1427 +1 Continue to review full report in Codecov by Sentry.
|
| assert.NotEmpty(t, secondFiles) | ||
|
|
||
| // v3.6 creates a raft log snapshot on server startup, but v3.5 doesn't | ||
| if lastVer.LessThan(version.V3_6) && (version.V3_6.Equal(*currVer) || version.V3_6.LessThan(*currVer)) { |
There was a problem hiding this comment.
Can we just compare snapshots from matching revisions and ignore other ones?
There was a problem hiding this comment.
Good idea. We can just ignore the first snapshot file of etcd v3.6. The rest should match.
…napshot file of etcd v3.6 Signed-off-by: Clement <[email protected]>
…napshot file of etcd v3.6 Signed-off-by: Clement <[email protected]>
Signed-off-by: Clement <[email protected]>
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: clement2026, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
#18494 creates a non-empty raft log snapshot on server startup. This means in v3.6, we'll see one more snapshot file compared to v3.5, and the data in these snapshot files will be different.
Part of #17098