Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.5] docs: remove warning that etcd 3.5.0 was not yet released #18579

Merged
merged 1 commit into from
Sep 15, 2024

Conversation

ghouscht
Copy link
Contributor

See description in #18410

@k8s-ci-robot
Copy link

Hi @ghouscht. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivanvc
Copy link
Member

ivanvc commented Sep 13, 2024

/ok-to-test

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Thomas.

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup!

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ghouscht, ivanvc, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 9e0e81e into etcd-io:release-3.5 Sep 15, 2024
28 checks passed
@ivanvc
Copy link
Member

ivanvc commented Nov 7, 2024

/retitle [3.5] docs: remove warning that etcd 3.5.0 was not yet released

@k8s-ci-robot k8s-ci-robot changed the title docs: remove warning that etcd 3.5.0 was not yet released [3.5] docs: remove warning that etcd 3.5.0 was not yet released Nov 7, 2024
@ivanvc ivanvc mentioned this pull request Nov 7, 2024
2 tasks
@ghouscht ghouscht deleted the issue-18410 branch November 7, 2024 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants