-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support scan-keys command to scan the key space starting a specific revision #18539
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 25 files with indirect coverage changes @@ Coverage Diff @@
## main #18539 +/- ##
==========================================
+ Coverage 68.73% 68.83% +0.10%
==========================================
Files 420 420
Lines 35470 35470
==========================================
+ Hits 24381 24417 +36
+ Misses 9668 9633 -35
+ Partials 1421 1420 -1 Continue to review full report in Codecov by Sentry.
|
d3c6a52
to
532a60c
Compare
As a followup, we also need to add a command |
532a60c
to
38b1ffd
Compare
…evision Signed-off-by: Benjamin Wang <[email protected]>
38b1ffd
to
cb2f7b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @ahrtr
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, Benjamin.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc, jmhbnz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The
etcd-dump-db scan-keys ...
is useful to analyze issue something like etcd-io/bbolt#778. It supports scanning the key space even the db is corrupted.Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.