Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support scan-keys command to scan the key space starting a specific revision #18539

Merged
merged 1 commit into from
Sep 9, 2024

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented Sep 4, 2024

The etcd-dump-db scan-keys ... is useful to analyze issue something like etcd-io/bbolt#778. It supports scanning the key space even the db is corrupted.

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.83%. Comparing base (4a11ca6) to head (def064f).

Current head def064f differs from pull request most recent head cb2f7b7

Please upload reports for the commit cb2f7b7 to get more accurate results.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

see 25 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #18539      +/-   ##
==========================================
+ Coverage   68.73%   68.83%   +0.10%     
==========================================
  Files         420      420              
  Lines       35470    35470              
==========================================
+ Hits        24381    24417      +36     
+ Misses       9668     9633      -35     
+ Partials     1421     1420       -1     

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a11ca6...cb2f7b7. Read the comment docs.

@ahrtr
Copy link
Member Author

ahrtr commented Sep 4, 2024

As a followup, we also need to add a command find-parent to find the parents in the B-tree of a specific page.

tools/etcd-dump-db/main.go Show resolved Hide resolved
tools/etcd-dump-db/page.go Outdated Show resolved Hide resolved
tools/etcd-dump-db/main.go Show resolved Hide resolved
tools/etcd-dump-db/meta.go Outdated Show resolved Hide resolved
tools/etcd-dump-db/scan.go Show resolved Hide resolved
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @ahrtr

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, Benjamin.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, ivanvc, jmhbnz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr ahrtr merged commit 42dd298 into etcd-io:main Sep 9, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants