-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Bump go toolchain to 1.22.7 #18444
Conversation
@ivanvc The devcontainer can't be updated now, because at the time of writing the 1.23 image hasn't been released yet. Please see: https://hubgw.docker.com/r/microsoft/devcontainers-go |
Reference: - etcd-io#18444 Signed-off-by: Chun-Hung Tseng <[email protected]>
93d1f98
to
fbd70e8
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 22 files with indirect coverage changes @@ Coverage Diff @@
## main #18444 +/- ##
==========================================
- Coverage 68.85% 68.81% -0.04%
==========================================
Files 420 420
Lines 35474 35474
==========================================
- Hits 24425 24411 -14
- Misses 9626 9639 +13
- Partials 1423 1424 +1 Continue to review full report in Codecov by Sentry.
|
@ivanvc I will resolve the CI error in the meantime. But we probably would be blocked by #18444 (comment) in any case. |
/test pull-etcd-govulncheck |
For the |
Hey Team - The devcontainer is now available following devcontainers/images#1167 |
9fac0cd
to
86eca3e
Compare
Hello @ahrtr, Thanks for the idea and insight! May I ask where exactly I should raise this issue? Thank you! |
I think https://github.com/kubernetes/test-infra, the image that may have the issue is: https://github.com/kubernetes/test-infra/tree/master/images/kubekins-e2e-v2. |
86eca3e
to
f00b67c
Compare
Thanks @ivanvc for the hint. I dug into the issue. As the k/k is still on 1.22, thus all the images are on 1.22 and not 1.23. I am thinking of submitting a PR to add a new variant that contains 1.23, but not sure if this is the best way to do it. @ivanvc do you have some ideas? I am happy to get involved in the prow / test-infra to get into this new field! :) |
@henrybear327, if you have the time and know what to do, I'd say go for it. :) |
@henrybear327, 1.23.1 was released today. Could you please update this PR to bump to the latest patch? Thanks. |
Ok! Should I bump others too? |
Yes, if you want, please refer to #18548 (and assign it to you). I'm doing 3.4 and 3.5 because we want to expedite them for the releases. |
/retitle [main] Bump go toolchain to 1.23.1 |
f00b67c
to
032f81c
Compare
@ahrtr @ivanvc as we have discussed at #18548 (comment) and offline, we will use 1.22.7 for the main branch now. I will work on the |
Reference: - etcd-io#18443 - etcd-io#18548 (comment) Signed-off-by: Chun-Hung Tseng <[email protected]>
032f81c
to
29f3bc2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @henrybear327
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, henrybear327, jmhbnz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Reference:
- Update main branch to Go 1.23 / release branches to 1.22 #18443Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.