Remove flake caused failpoint in watch disrupting progress notifies #18392
Conversation
Signed-off-by: Marek Siarkowicz <[email protected]>
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| @@ -96,8 +96,11 @@ func testRobustness(ctx context.Context, t *testing.T, lg *zap.Logger, s testSce | |||
| t.Fatal(err) | |||
| } | |||
|
|
|||
| watchProgressNotifyEnabled := c.Cfg.ServerConfig.ExperimentalWatchProgressNotifyInterval != 0 | |||
| validateGotAtLeastOneProgressNotify(t, r.Client, s.watch.requestProgress || watchProgressNotifyEnabled) | |||
| failpointImpactingWatch := s.failpoint == failpoint.SleepBeforeSendWatchResponse | |||
There was a problem hiding this comment.
this seems to be a important failpoint to test progress notify. Is there plan to investigate further?
There was a problem hiding this comment.
No, with progress notifies not being guaranteed in every situation, it's hard to make a strong requirement on them when we use failpoints that directly disrupt their delivery. We can consider revisiting it only after we improve etcd progress guarantees.
|
/retest |
cc @ahrtr @siyuanfoundation @fuweid @MadhavJivrajani