Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release.md #18346

Closed
wants to merge 0 commits into from
Closed

Update release.md #18346

wants to merge 0 commits into from

Conversation

wenjiaswe
Copy link
Contributor

Update release.md based on 3.5.15 release: #18247 (comment)

@wenjiaswe
Copy link
Contributor Author

cc @jmhbnz @ivanvc

@@ -62,6 +62,7 @@ which don't need to be executed before releasing each version.
4. Authenticate the image registry, refer to [Authentication methods](https://cloud.google.com/container-registry/docs/advanced-authentication).
- `gcloud auth login`
- `gcloud auth configure-docker`
5. Make sure your Linux machine has at least 5GB free space.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @wenjiaswe, I suggest rather changing pre-req 2c, that says:

Ensure there is at least 500MB of free space on your Linux machine.

- Follow the format of previous release pages
- Attach the generated binaries and signature file
- Select whether it's a pre-release
- Publish the release
6. Announce to the etcd-dev googlegroup

Follow the format of previous release emails sent to [email protected], see an example below,
Follow the format of previous release emails sent to [email protected], see an example below. After sending out the email, ask one of the mainterners to approve the email from the pending list.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo but lets also tweak it to "mailing list maintainers" as this doesn't necessarily have to only be project code maintainers in future 🙂

Suggested change
Follow the format of previous release emails sent to [email protected], see an example below. After sending out the email, ask one of the mainterners to approve the email from the pending list.
Follow the format of previous release emails sent to [email protected], see an example below. After sending out the email, ask one of the mailing list maintainers to approve the email from the pending list.

@jmhbnz
Copy link
Member

jmhbnz commented Jul 22, 2024

/retest

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: serathius, wenjiaswe

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

@wenjiaswe: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-robustness-amd64 f181ced link false /test pull-etcd-robustness-amd64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants