-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHANGELOG Differentiate the warning message for rejected client and peer connections for release-3.5 #18320
Conversation
…ted client and peer connections Signed-off-by: Benjamin Wang <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted filessee 17 files with indirect coverage changes @@ Coverage Diff @@
## main #18320 +/- ##
==========================================
+ Coverage 68.87% 68.97% +0.10%
==========================================
Files 417 417
Lines 35333 35333
==========================================
+ Hits 24334 24370 +36
+ Misses 9577 9550 -27
+ Partials 1422 1413 -9 Continue to review full report in Codecov by Sentry.
|
@ahrtr: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @ahrtr
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, jmhbnz The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retitle CHANGELOG Differentiate the warning message for rejected client and peer connections for release-3.5 |
Related to #18319
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.