-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[3.5] client/v3/watch.go: use fmt go pkg for gRPC metadata map printing #18312
[3.5] client/v3/watch.go: use fmt go pkg for gRPC metadata map printing #18312
Conversation
Hi @mohamedawnallah. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Mohamed Awnallah <[email protected]>
Signed-off-by: Mohamed Awnallah <[email protected]> Co-authored-by: Benjamin Wang <ahrtr>
095eebe
to
1bfca72
Compare
/retitle [3.5] client/v3/watch.go: use fmt go pkg for gRPC metadata map printing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - Thanks @mohamedawnallah
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @mohamedawnallah.
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: ahrtr, ivanvc, jmhbnz, mohamedawnallah The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
In this commit, we update the changelog for gRPC metadata printing in release 3.5 which is mainly a backport from PR etcd-io#18312. Signed-off-by: Mohamed Awnallah <[email protected]>
In this commit, we update the changelog for gRPC metadata printing in release 3.5 which is mainly a backport from PR etcd-io#18312. Signed-off-by: Mohamed Awnallah <[email protected]>
In this commit, we update the changelog for gRPC metadata printing in release 3.5 which is mainly a backport from PR etcd-io#18312. Signed-off-by: Mohamed Awnallah <[email protected]>
In this commit, we update the changelog for gRPC metadata printing in release 3.5 which is mainly a backport from PR etcd-io#18312. Signed-off-by: Mohamed Awnallah <[email protected]>
In this commit, we update the changelog for gRPC metadata printing in release 3.5 which is mainly a backport from PR etcd-io#18312. Signed-off-by: Mohamed Awnallah <[email protected]>
In this commit, we update the changelog for gRPC metadata printing in release 3.5 which is mainly a backport from PR etcd-io#18312. Signed-off-by: Mohamed Awnallah <[email protected]>
…tgRPCMetadata [3.5] client/v3/watch.go: use fmt go pkg for gRPC metadata map printing
Description
This PR backports the changes from #18308 PR to the release-3.5 branch.
Issue
Addresses Issue #18303 in the backport release-3.5.