Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.5] Suppress noisy basic auth token deletion log #18265

Merged
merged 1 commit into from
Jul 3, 2024
Merged

[3.5] Suppress noisy basic auth token deletion log #18265

merged 1 commit into from
Jul 3, 2024

Conversation

k8s-infra-cherrypick-robot
Copy link

This is an automated cherry-pick of #18245

/assign ivanvc

@ahmetb
Suppress noisy basic auth token deletion log
0a960a2 
Right now the basic auth tokens that are deleted after `--auth-token-ttl`
cause info-level logs to be emitted. Change this to debug. This helps with
the issue at etcd-io#18244 where calling `/readyz` frequently pollutes the etcd server
logs with this log message.

Fixes etcd-io#18244.

Signed-off-by: Ahmet Alp Balkan <[email protected]>
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jul 2, 2024
Merged
@k8s-ci-robot
Copy link

Hi @k8s-infra-cherrypick-robot. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivanvc
Copy link
Member

ivanvc commented Jul 2, 2024

/retitle [3.5] Suppress noisy basic auth token deletion log

@k8s-ci-robot k8s-ci-robot changed the title [release-3.5] Suppress noisy basic auth token deletion log [3.5] Suppress noisy basic auth token deletion log Jul 2, 2024
@ivanvc
Copy link
Member

ivanvc commented Jul 2, 2024

/ok-to-test

jmhbnz
jmhbnz approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ivanvc
ivanvc approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

fuweid
fuweid approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@fuweid fuweid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ahrtr ahrtr merged commit f2b9662 into etcd-io:release-3.5 Jul 3, 2024
27 checks passed
@ivanvc ivanvc mentioned this pull request Jul 3, 2024
Closed
4 tasks
aneesh1 pushed a commit to DataDog/etcd that referenced this pull request Sep 24, 2024
@ahrtr @aneesh1
Merge pull request etcd-io#18265 from k8s-infra-cherrypick-robot/cher…
37c1aed 
…ry-pick-18245-to-release-3.5

[3.5] Suppress noisy basic auth token deletion log
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmhbnz jmhbnz jmhbnz approved these changes

@ahrtr ahrtr ahrtr approved these changes

@liangyuanpeng liangyuanpeng liangyuanpeng approved these changes

@fuweid fuweid fuweid approved these changes

@ivanvc ivanvc ivanvc approved these changes

Assignees

@ivanvc ivanvc

Labels
ok-to-test size/XS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@k8s-infra-cherrypick-robot @k8s-ci-robot @ivanvc @fuweid @liangyuanpeng @ahrtr @jmhbnz @ahmetb