[3.5] github/govuln: don't swallow govulncheck errors #18254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By running `find -exec`, an error exit code doesn't properly return the error if there's a failure in a command executed. Use `xargs` to force an exit with error when a command fails to run. Signed-off-by: Ivan Valdes <[email protected]>
ivanvc
changed the title
aneesh1
pushed a commit
to DataDog/etcd
that referenced
this pull request
Sep 24, 2024
…-govulncheck-exit-code [3.5] github/govuln: don't swallow govulncheck errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By running
find -exec, an error exit code doesn't properly return the error if there's a failure in a command executed. Usexargsto force an exit with an error when a command fails to run.Refer to https://github.com/ivanvc/etcd/actions/runs/9727114371/job/26846300969 for an example of a run that should have failed but didn't.
After updating the workflow to use
xargs, this is a build with a failure: https://github.com/ivanvc/etcd/actions/runs/9727235294/job/26846574320Fixes #18173
Related to Slack thread: https://kubernetes.slack.com/archives/C3HD8ARJ5/p1719591918822359
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.