Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

etcd-client: Clean up unnecessary nil Logger check #18243

Merged
merged 1 commit into from
Jun 28, 2024
Merged

etcd-client: Clean up unnecessary nil Logger check #18243

merged 1 commit into from
Jun 28, 2024

Conversation

masonyc
Copy link
Contributor

@masonyc masonyc commented Jun 28, 2024

Clean up unnecessary nil Logger for listener.go as pointed out in issue #18084

@masonyc
etcdclient: Clena up unnecessary nil Logger check
7dec366 
Clean up unnecessary nil Logger for listener.go as pointed out in issue
etcd-io#18084

Signed-off-by: Mason Chen <[email protected]>
@k8s-ci-robot
Copy link

Hi @masonyc. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@jmhbnz
Copy link
Member

jmhbnz commented Jun 28, 2024

/ok-to-test

ahrtr
ahrtr approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks for the cleanup!

jmhbnz
jmhbnz approved these changes Jun 28, 2024
View reviewed changes
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thanks @masonyc

@jmhbnz jmhbnz merged commit 1c22e7b into etcd-io:main Jun 28, 2024
51 checks passed
@masonyc masonyc deleted the cleanup-unneeded-logger-check branch June 28, 2024 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmhbnz jmhbnz jmhbnz approved these changes

@ahrtr ahrtr ahrtr approved these changes

@serathius serathius serathius approved these changes

Assignees
No one assigned
Labels
backport/v3.5 ok-to-test size/L type/cleanup
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@masonyc @k8s-ci-robot @jmhbnz @serathius @ahrtr