Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

increase/commit auth revision when auth enable #18236

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

andyxning
Copy link
Contributor

Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.

Since all the auth store update function should update auth revision, i.e., calling commitRevision.
AuthEnable has already called commitRevision, AuthDisable also should call commitRevision.

@k8s-ci-robot
Copy link

Hi @andyxning. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@andyxning andyxning force-pushed the increate_auth_revision_when_auth_enable branch 2 times, most recently from 5d55929 to 09f9b4b Compare June 26, 2024 12:23
@andyxning andyxning force-pushed the increate_auth_revision_when_auth_enable branch from 09f9b4b to 0bfe109 Compare June 26, 2024 12:23
@jmhbnz
Copy link
Member

jmhbnz commented Aug 4, 2024

/ok-to-test

@serathius
Copy link
Member

If you think the current behavior is incorrect, please add tests showing (both unit and e2e)

@k8s-ci-robot
Copy link

@andyxning: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-etcd-unit-test-386 0bfe109 link true /test pull-etcd-unit-test-386
pull-etcd-unit-test-amd64 0bfe109 link true /test pull-etcd-unit-test-amd64
pull-etcd-unit-test-arm64 0bfe109 link true /test pull-etcd-unit-test-arm64

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants