-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build(deps): bump github/codeql-action from 3.25.3 to 3.25.5 #18001
build(deps): bump github/codeql-action from 3.25.3 to 3.25.5 #18001
Conversation
Hi @dependabot[bot]. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #18001 +/- ##
==========================================
+ Coverage 68.90% 69.04% +0.14%
==========================================
Files 415 415
Lines 34963 34963
==========================================
+ Hits 24091 24140 +49
+ Misses 9481 9439 -42
+ Partials 1391 1384 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
/retest |
Bumps [github/codeql-action](https://github.com/github/codeql-action) from 3.25.3 to 3.25.5. - [Release notes](https://github.com/github/codeql-action/releases) - [Changelog](https://github.com/github/codeql-action/blob/main/CHANGELOG.md) - [Commits](github/codeql-action@d39d31e...b7cec75) --- updated-dependencies: - dependency-name: github/codeql-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]>
aa2f767
to
d82560e
Compare
@@ -67,6 +67,6 @@ jobs: | |||
format: 'sarif' | |||
output: 'trivy-results-${{ matrix.platforms }}.sarif' | |||
- name: upload scan results | |||
uses: github/codeql-action/upload-sarif@d39d31e687223d841ef683f52467bd88e9b21c14 # v2.16.6 | |||
uses: github/codeql-action/upload-sarif@b7cec7526559c32f1616476ff32d17ba4c59b2d6 # v2.16.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the commented tag doesn't match the commit sha 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jmhbnz, I'll recreate this PR addressing the wrong commented version (https://github.com/etcd-io/etcd/pull/18001/files#r1599022238)
Good spotting - Yeah let's tidy it up so dependabot will auto update it moving forward 👍🏻 |
Looks like github/codeql-action is up-to-date now, so this is no longer needed. |
Bumps github/codeql-action from 3.25.3 to 3.25.5.
Changelog
Sourced from github/codeql-action's changelog.
... (truncated)
Commits
b7cec75
Merge pull request #2287 from github/update-v3.25.5-4a51972476778fe4
Update changelog for v3.25.54a51972
Merge pull request #2280 from github/henrymercer/on-demand-ffsa8c32fd
Merge pull request #2283 from github/henrymercer/disable-fail-fastf73b0b7
Disable fail fast for non-generated workflowsc59e052
Disable fail fast in generated workflows33e416c
Comment thatlegacyApi
is false by default67f8a36
Merge branch 'main' into henrymercer/on-demand-ffs4995c49
Merge pull request #2282 from github/henrymercer/no-build-mode-tracing-improv...def4d2c
Merge pull request #2273 from github/aeisenberg/specify-versionsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)