-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Manually bump dependencies #17932
Manually bump dependencies #17932
Conversation
Signed-off-by: Sharath Sivakumar <[email protected]>
…from 1.25.0 to 1.26.0 Signed-off-by: Sharath Sivakumar <[email protected]>
Hi @sharathsivakumar. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
Hi @sharathsivakumar, thanks for the PR. It looks like
|
@ivanvc Thanks for looking into this. It is bumped. Only that, it was bumped by another package. I think the go mod tidy bumped it while upgrading otel/trace. |
go.opentelemetry.io/otel v1.25.0 | ||
go.opentelemetry.io/otel/sdk v1.25.0 | ||
go.opentelemetry.io/otel/trace v1.25.0 | ||
go.opentelemetry.io/otel v1.26.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ivanvc you can check here!
go.opentelemetry.io/otel v1.25.0 | ||
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.25.0 | ||
go.opentelemetry.io/otel/sdk v1.25.0 | ||
go.opentelemetry.io/otel v1.26.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ivanvc and here!
@ivanvc I have left comments where it has been bumped. Can you please check and verify it. I think I did not mention this in the MR description. Thats fixed as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Got it, thanks @sharathsivakumar.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks
Here are the dependencies for this week:
Please let me know if any changes are required