Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually bump dependencies #17932

Merged
merged 2 commits into from
May 4, 2024
Merged

Manually bump dependencies #17932

merged 2 commits into from
May 4, 2024

Conversation

@k8s-ci-robot
Copy link

Hi @sharathsivakumar. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ivanvc
Copy link
Member

ivanvc commented May 3, 2024

/ok-to-test

@ivanvc
Copy link
Member

ivanvc commented May 3, 2024

Hi @sharathsivakumar, thanks for the PR. It looks like go.opentelemetry.io/otel #17910 is not indirect; it's used by tests and server. Refer to the following snippet:

etcdutl/go.mod
61:     go.opentelemetry.io/otel v1.25.0 // indirect

tests/go.mod
39:     go.opentelemetry.io/otel v1.25.0

server/go.mod
34:     go.opentelemetry.io/otel v1.25.0

go.mod
82:     go.opentelemetry.io/otel v1.25.0 // indirect

@sharathsivakumar
Copy link
Contributor Author

@ivanvc Thanks for looking into this. It is bumped. Only that, it was bumped by another package. I think the go mod tidy bumped it while upgrading otel/trace.

go.opentelemetry.io/otel v1.25.0
go.opentelemetry.io/otel/sdk v1.25.0
go.opentelemetry.io/otel/trace v1.25.0
go.opentelemetry.io/otel v1.26.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivanvc you can check here!

go.opentelemetry.io/otel v1.25.0
go.opentelemetry.io/otel/exporters/otlp/otlptrace/otlptracegrpc v1.25.0
go.opentelemetry.io/otel/sdk v1.25.0
go.opentelemetry.io/otel v1.26.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ivanvc and here!

@sharathsivakumar
Copy link
Contributor Author

@ivanvc I have left comments where it has been bumped. Can you please check and verify it. I think I did not mention this in the MR description. Thats fixed as well.

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it, thanks @sharathsivakumar.
/lgtm

@ivanvc
Copy link
Member

ivanvc commented May 4, 2024

@ahrtr, @jmhbnz PTAL :)

Copy link
Member

@ahrtr ahrtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks

@ahrtr ahrtr merged commit 301c74c into etcd-io:main May 4, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants