Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate
main
to golang1.20
, as1.19
is now out of support.One task towards #16393
Ran some benchmarks between this branch and
main
locally as follows:etcd Version: 3.6.0-alpha.0
Go Version: go1.20.7
Go OS/Arch: linux/amd64
Total: 468.3909 secs.
Slowest: 0.0711 secs.
Fastest: 0.0026 secs.
Average: 0.0150 secs.
Stddev: 0.0065 secs.
Requests/sec: 4269.9374
Total: 468.5622 secs.
Slowest: 0.0873 secs.
Fastest: 0.0030 secs.
Average: 0.0150 secs.
Stddev: 0.0065 secs.
Requests/sec: 4268.3772
Total: 467.0949 secs.
Slowest: 0.0751 secs.
Fastest: 0.0025 secs.
Average: 0.0149 secs.
Stddev: 0.0065 secs.
Requests/sec: 4281.7851
etcd Version: 3.6.0-alpha.0
Go Version: go1.19.12
Go OS/Arch: linux/amd64
Total: 469.1479 secs.
Slowest: 0.0775 secs.
Fastest: 0.0030 secs.
Average: 0.0150 secs.
Stddev: 0.0066 secs.
Requests/sec: 4263.0482
Total: 467.0527 secs.
Slowest: 0.0659 secs.
Fastest: 0.0025 secs.
Average: 0.0149 secs.
Stddev: 0.0065 secs.
Requests/sec: 4282.1723
Total: 467.0527 secs.
Slowest: 0.0659 secs.
Fastest: 0.0025 secs.
Average: 0.0149 secs.
Stddev: 0.0065 secs.
Requests/sec: 4282.1723