Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a top level OWNERS file to top each etcd.io subproject #16367

Closed
wenjiaswe opened this issue Aug 3, 2023 · 13 comments
Closed

Add a top level OWNERS file to top each etcd.io subproject #16367

wenjiaswe opened this issue Aug 3, 2023 · 13 comments
Assignees
@thedtripp @jmhbnz
Labels
area/community backport/v3.4 backport/v3.5 type/feature

Comments

@wenjiaswe
Copy link
Contributor

What would you like to be added?

Add a top level OWNERS file to top each etcd.io subproject.

Why is this needed?

It's a hard requirement to set up sig-etcd: kubernetes/community#7372 (comment).
@wenjiaswe wenjiaswe self-assigned this Aug 3, 2023
wenjiaswe added a commit to logicalhan/community that referenced this issue Aug 3, 2023
@wenjiaswe
Update charter.md to remove OWNERS file from deviation
4c15368 
Adding OWNERS file will be a hard requirement for etcd repo. I also added an issue in etcd repo for tracking: etcd-io/etcd#16367.
@wenjiaswe wenjiaswe mentioned this issue Aug 3, 2023
Merged
wenjiaswe added a commit to logicalhan/community that referenced this issue Aug 30, 2023
@wenjiaswe
Update charter.md to remove OWNERS file from deviation
cee917c 
Adding OWNERS file will be a hard requirement for etcd repo. I also added an issue in etcd repo for tracking: etcd-io/etcd#16367.
k8s-ci-robot pushed a commit to kubernetes/community that referenced this issue Sep 12, 2023
@jberkus @serathius
@wenjiaswe @ahrtr @sftim
set up SIG-etcd (#7372)
3edd1c6 
* Create SIG-etcd

Co-authored-by: Josh Berkus <[email protected]>
Co-authored-by: Marek Siarkowicz <[email protected]>

* Remove unnecessary eviations

* Update sig-etcd/charter.md

Co-authored-by: Benjamin Wang <[email protected]>

* Update charter.md to remove OWNERS file from deviation

Adding OWNERS file will be a hard requirement for etcd repo. I also added an issue in etcd repo for tracking: etcd-io/etcd#16367.

* update charter.md, vision.md and README.md to address comments

* update sig-etcd with new chairs

* Update charter.md

* Update charter.md to include implicit k8s-etcd-contract as part of sig-etcd's responsibility in a sentence, instead of a linked google doc

* Update sig-etcd/vision.md

Co-authored-by: Tim Bannister <[email protected]>

* Update sig-etcd/vision.md

Co-authored-by: Tim Bannister <[email protected]>

* update etcd meeting link, time and youtube link

---------

Co-authored-by: Josh Berkus <[email protected]>
Co-authored-by: Marek Siarkowicz <[email protected]>
Co-authored-by: Wenjia <[email protected]>
Co-authored-by: Benjamin Wang <[email protected]>
Co-authored-by: Tim Bannister <[email protected]>
@jmhbnz
Copy link
Member

jmhbnz commented Sep 12, 2023 •
edited
Loading

Here is our list of all repos for reference:

Archive - Don't add OWNERS:

OWNERS file completed

@jmhbnz
Copy link
Member

jmhbnz commented Sep 15, 2023 •
edited
Loading

Hey Team - I've confirmed with @mrbobbytables that repositories marked as public archive do not need to be included in this work of seeding initial OWNERS files.

With that in mind I would like to propose @etcd-io/maintainers-etcd mark the etcd-io/maintainers, etcd-io/zetcd and etcd-io/cetd repositories as public archive as they are no longer maintained.

Based on my list above that would then leave us 12 pr's to raise. I have made a start on the first one to get us moving: #16600

This was referenced Sep 16, 2023
Merged
Merged
Merged
Open
Open
Merged
This was referenced Sep 26, 2023
Open
Merged
Open
@jmhbnz
Copy link
Member

jmhbnz commented Oct 8, 2023 •
edited
Loading

Update: All required OWNERS files have now been merged. There were four repositories proposed for public archival, 3/4 have been completed, the other one is in progress pending maintainer majority approval.

We have an active pr in progress on the kubernetes/org repo to implement automated management for the etcd-io org: kubernetes/org#4498.

Once that is merged we should cleanup to ensure:
1 - Any process documentation about repository access management is updated
2 - Remove the now defunct / duplicate MAINTAINERS files.

The following repositories will need a cleanup pr to at minimum remove old MAINTAINERS file:

This was referenced Oct 18, 2023
Merged
Merged
Merged
Merged
Merged
@jmhbnz
Copy link
Member

jmhbnz commented Nov 9, 2023

All etcd-io subprojects now have a top level OWNERS file where required and followup action to tidy up old MAINTAINERS files has also been completed, closing.

As a next step we should begin exploring more fine grained code ownership for specific aspects of etcd-io/etcd but that can be addressed in subsequent issues.

@jmhbnz jmhbnz closed this as completed Nov 9, 2023
@jmhbnz jmhbnz mentioned this issue Jul 5, 2024
Merged
@jmhbnz
Copy link
Member

jmhbnz commented Jul 8, 2024

Reopen to backport OWNERS to release-3.5 and release-3.4 in support of improved automation via prow.

@jmhbnz jmhbnz reopened this Jul 8, 2024
@jmhbnz jmhbnz assigned jmhbnz and unassigned wenjiaswe Aug 1, 2024
@jmhbnz
Copy link
Member

jmhbnz commented Aug 1, 2024

Discussed during sig-etcd triage meeting, assigned to @thedtripp for backport #16794 to release-3.5 and release-3.4.

/assign @thedtripp

@k8s-ci-robot
Copy link

@jmhbnz: GitHub didn't allow me to assign the following users: thedtripp.

Note that only etcd-io members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

Discussed during sig-etcd triage meeting, assigned to @thedtripp for backport #16794 to release-3.5 and release-3.4.

/assign @thedtripp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@thedtripp
Copy link
Member

thedtripp commented Aug 1, 2024 •
edited
Loading

/assign @thedtripp

@k8s-ci-robot
Copy link

@thedtripp: GitHub didn't allow me to assign the following users: thrdtripp.

Note that only etcd-io members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @thrdtripp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@thedtripp
Copy link
Member

/assign @thedtripp

This was referenced Aug 2, 2024
Merged
Merged
@jmhbnz
Copy link
Member

jmhbnz commented Aug 12, 2024

Hey @thedtripp - Now that we have release-3.5 completed do you have capacity to also tackle the backport release-3.4 so we can close this out? 🙏🏻

@thedtripp
Copy link
Member

Hey @jmhbnz, yes, I will work on this over the next few days.

@thedtripp thedtripp mentioned this issue Aug 15, 2024
Merged
@jmhbnz
Copy link
Member

jmhbnz commented Aug 16, 2024

Backports completed - closing 🎉

@jmhbnz jmhbnz closed this as completed Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thedtripp thedtripp

@jmhbnz jmhbnz

Labels
area/community backport/v3.4 backport/v3.5 type/feature
Milestone
No milestone
Development

No branches or pull requests
4 participants
@k8s-ci-robot @wenjiaswe @thedtripp @jmhbnz