Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable bootstrapping statefulsets #12

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

abdurrehman107
Copy link

@abdurrehman107 abdurrehman107 commented Dec 17, 2024

What this PR does:
This PR enables bootstrapping StatefulSets. The controller:

  1. Fetches the EtcdCluster resource.
  2. Checks for an existing StatefulSet:
    • If missing and Spec.Size > 0, creates a StatefulSet with replicas = 0.
  3. Sets ownership using SetControllerReference for proper garbage collection.

It follows the workflow mentioned here.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: abdurrehman107
Once this PR has been reviewed and has the lgtm label, please assign ahrtr for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ahrtr
Copy link
Member

ahrtr commented Dec 17, 2024

Thanks @abdurrehman107 for the PR. Based on our discussion in last WG meeting, @ Gaurav Dasson is supposed to deliver a PR for this. I am not sure what's his progress so far. Let me ping him in slack.

Also I'd like to see a complete PR to transfer all the implementation of syncHandler (around 300 -400 lines of code).

@ahrtr
Copy link
Member

ahrtr commented Dec 19, 2024

@abdurrehman107 since there is no response from Gaurav Dasson, please feel free to continue to work on this. Could you deliver a complete PR to transfer all the implementation of syncHandler (around 300 -400 lines of code)?

@ahrtr
Copy link
Member

ahrtr commented Dec 19, 2024

The goal is to implement the initial Reconcile workflow based on syncHandler . Please ensure that you verify it in a K8s cluster. thx

@abdurrehman107
Copy link
Author

Could you deliver a complete PR to transfer all the implementation of syncHandler (around 300 -400 lines of code)?

Yes I can. I'll ask for help in the wg slack channel.

Please ensure that you verify it in a K8s cluster. thx

Aighty.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants