-
Notifications
You must be signed in to change notification settings - Fork 646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changelog for 1.4.0-beta.0 #847
Conversation
Sorry about the robustness failure. It's due to a prow infra current limitation, I'm aware and tracking it. Should we add a note regarding Go 1.23.2? I see that previous releases did mention the Go version used (#836). |
a6db331
to
2709ffc
Compare
@ahrtr: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Thanks for the reminder. Updated the changelog to only mention that it requires 1.23.x. bbolt is used as a library, it's up to users/application to decide the exact go version. We just need to clear call out the minor go version.
Thanks. If it needs a long time to resolve the issue (i.e. > 2 months), can we add it back to github for now (without arm64)? |
PTAL at kubernetes/test-infra#33735. I say let's hold them to avoid the noise. Restoring them should be quick. |
Signed-off-by: Benjamin Wang <[email protected]>
2709ffc
to
1a4cb44
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks, @ahrtr.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, ivanvc The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
cc @fuweid @jmhbnz @serathius @tjungblu for awareness |
Link to #553