Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd: enhance the surgery commands #483

Merged
merged 2 commits into from
May 7, 2023
Merged

cmd: enhance the surgery commands #483

merged 2 commits into from
May 7, 2023

Conversation

ahrtr
Copy link
Member

@ahrtr ahrtr commented May 5, 2023 •
edited
Loading

@ahrtr ahrtr mentioned this pull request May 5, 2023
Merged
serathius
serathius approved these changes May 7, 2023
View reviewed changes
Copy link
Member

@serathius serathius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good improvement, I would recommend decomposing struct per command, I can help with that.

@serathius serathius merged commit 179e020 into etcd-io:master May 7, 2023
@ahrtr
Copy link
Member Author

ahrtr commented May 7, 2023

I would recommend decomposing struct per command, I can help with that.

Makes sense to me. We can have one base struct with only surgeryTargetDBFilePath, and three additional structs for clear-page, clear-page-element and copy-page commands respectively, each of them has a nested base struct. Please feel free to deliver a PR after #484 gets merged. thx

@serathius
Copy link
Member

PTAL #485

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serathius serathius serathius approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahrtr @serathius