Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

runtime/container: --log-driver=none for connector containers #1735

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

mdibaiee
Copy link
Member

@mdibaiee mdibaiee commented Oct 24, 2024

Description:

  • Add --log-driver=none for container connectors, since we don't want to retain their logs, given that their logs are available as gazette journals

Workflow steps:

(How does one use this feature, and how has it changed)

Documentation links affected:

(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)

Notes for reviewers:

(anything that might help someone review this PR)


This change is Reviewable

@mdibaiee mdibaiee added the change:unplanned This change is unplanned, useful for things like docs label Oct 24, 2024
Copy link
Member

@jgraettinger jgraettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mdibaiee mdibaiee merged commit 04e8740 into master Oct 24, 2024
3 checks passed
@mdibaiee mdibaiee deleted the mahdi/log-driver-none branch October 24, 2024 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change:unplanned This change is unplanned, useful for things like docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants