Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

assemble: set default flush_interval to 24h #1732

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Conversation

mdibaiee
Copy link
Member

@mdibaiee mdibaiee commented Oct 22, 2024

Description:

If there is no flushInterval set on the journal template, set a 24h flushInterval on journal fragments

Workflow steps:

(How does one use this feature, and how has it changed)

Documentation links affected:

(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)

Notes for reviewers:

(anything that might help someone review this PR)


This change is Reviewable

@mdibaiee mdibaiee force-pushed the mahdi/flushinterval branch 4 times, most recently from 5650ead to 2235635 Compare October 23, 2024 12:30
Copy link
Member

@jgraettinger jgraettinger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jgraettinger jgraettinger merged commit 60e47f6 into master Oct 25, 2024
3 checks passed
@jgraettinger jgraettinger deleted the mahdi/flushinterval branch October 25, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants