Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dekaf: Add metrics to track fetch request counts by topic and partition #1730

Closed
wants to merge 2 commits into from

Conversation

jshearer
Copy link
Contributor

@jshearer jshearer commented Oct 22, 2024

Description:

In order to debug what's happening with infrequent consumer lags, we want to keep track of how many read requests Dekaf is getting, broken down by collection and partition. This tracks that, as well as breaking down by read request type:

  • state => read_pending means the read request came in after a previous request had already fetched the same offset for the topic and partition, and that request is pending.
  • state => collection_not_found and state => partition_not_found are self-evident, though I believe a normal Kafka consumer would have figured out that these topics don't exist during the metadata discovery phase
  • state => new_data_preview_read indicates a fetch request that we flagged as being for a data preview. These requests have special handling and poison the entire connection to only be usable for other data preview reads
  • state => new_regular_read indicates a fetch request for a new topic/partition/offset combination.

Ex:

# TYPE dekaf_fetch_requests counter
dekaf_fetch_requests{topic_name="joseph/dekaf-testing",partition_index="0",state="new_regular_read"} 19
dekaf_fetch_requests{topic_name="joseph/dekaf-testing",partition_index="0",state="read_pending"} 248

This change is Reviewable

@jshearer jshearer changed the title dekaf: Add metrics to track fetch requests by topic and partition dekaf: Add metrics to track fetch request counts by topic and partition Oct 22, 2024
@jshearer
Copy link
Contributor Author

Rolled into #1733

@jshearer jshearer closed this Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant