Phil/agent logs #1388
Merged
Phil/agent logs #1388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The earlier change to enable logging on span close had missed a few spans that needed an explicit `level = "debug"`.
The idea is just to make it easy for us to get a sense of the end-to-end processing latency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
#1379 changed our
tracing_subscriberconfiguration to log at the close of each span. That required updating some#[instrument]attributes to includelevel = "debug", since the default level of spans isINFO. Apparently I missed a couple, so here we are. Production is currently logging pretty noisily, and this should help tone it down.Also, I added
time_queuedlog field to each async job handler, so we can get a sense of end-to-end processing latency. In retrospect, I wish I would have done this before making all these improvements to it, but 🤷This change is