Phil/discover name validation #1365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psFried
force-pushed
the
phil/discover-name-validation
branch
from
f33184e
to
52ced95
Compare
jgraettinger
approved these changes
Feb 5, 2024
|
Yeah, the agent will still fail. I was thinking that it's essentially a connector bug, and that for now just having better visibility is helpful. Happy to add another commit to either make this a draft error or normalize the empty string to something else. IMO, making it a draft error is probably the better option at this stage. |
|
K, I think we punt for now but do want to remember this, because it could come up once we allow user-defined connectors. |
When the discovered response doesn't include a `recommended_name` for one of the bindings, insert a draft error instead of crashing the agent. This is really a connector bug, but we want the agent to be tolerant of those.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Addresses a bug I found while troubleshooting a production issue, and adds better logging in case we try to insert another draft spec with an invalid name. The lack of normalization was not the cause of the issue we saw last week, but it certainly would present similarly if a connector returned a recommended collection name that wasn't normalized, since nfkc normalization is required by our postgres constraints.
This change is