connector-init: start listening on tcp port before check_protocol #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdibaiee
force-pushed
the
mahdi/flowctl-raw-discover
branch
3 times, most recently
from
b29ee73
to
1d214fc
Compare
mdibaiee
commented
Jul 27, 2023
crates/flowctl/src/connector.rs
Outdated
| "--publish", &format!("0.0.0.0:{}:{}/tcp", port, CONNECTOR_INIT_PORT), | ||
| "--entrypoint", | ||
| target_connector_init, | ||
| "--mount", &format!("type=bind,source={host_inspect_str},target={target_inspect}"), | ||
| image, | ||
| &format!("--image-inspect-json-path={target_inspect}"), | ||
| &format!("--port={CONNECTOR_INIT_PORT}"), | ||
| ], args].concat()) |
There was a problem hiding this comment.
Updated the arguments here to match the ones in container.go
There was a problem hiding this comment.
rust fmt? perhaps sort --flags ?
Also remove LOG_LEVEL=trace ? that's going to be very verbose.
mdibaiee
changed the title
jgraettinger
approved these changes
Jul 28, 2023
crates/flowctl/src/connector.rs
Outdated
| "--publish", &format!("0.0.0.0:{}:{}/tcp", port, CONNECTOR_INIT_PORT), | ||
| "--entrypoint", | ||
| target_connector_init, | ||
| "--mount", &format!("type=bind,source={host_inspect_str},target={target_inspect}"), | ||
| image, | ||
| &format!("--image-inspect-json-path={target_inspect}"), | ||
| &format!("--port={CONNECTOR_INIT_PORT}"), | ||
| ], args].concat()) |
There was a problem hiding this comment.
rust fmt? perhaps sort --flags ?
Also remove LOG_LEVEL=trace ? that's going to be very verbose.
mdibaiee
force-pushed
the
mahdi/flowctl-raw-discover
branch
from
4509740
to
3d54630
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
connector-initas soon as possible, but we don't process the requests while we check the protocol. After we have checked the protocol, we use the incoming stream to serve requests.flowctl'sdocker_runnot being able to clearly distinguish between a port that it can connect to, and a port that is ready for data to be written to it here. It's still a mystery to me how the go implementation of the same connection works fine and waits until the grpc server actually starts processing before it considers the connection as ready. The relevant go code is here and Tonic seems to conceptually check for readiness here, however it seems it has a different formulation of readiness.I still don’t love this, because I would like to understand why the tonic client considers the connection ready and the go client doesn’t, and ideally we would have the tonic client behave similar to the go client…
Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)
This change is