Skip to content

Commit

Permalink
PR review feedback:
Browse files Browse the repository at this point in the history
* Factor out `ObjShape::widen`
* Refactor to be zero-cost by default
* Ensure ObjShape.properties stays sorted
* Get rid of the helper function `Shape::widen_inner`
* Set `is_required` for new fields properly based on whether they have always been present or not
  • Loading branch information
jshearer committed Jul 27, 2023
1 parent 7196176 commit a10c844
Show file tree
Hide file tree
Showing 2 changed files with 201 additions and 123 deletions.
2 changes: 1 addition & 1 deletion Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ assert_cmd = "2.0"
criterion = "0.3"
glob = "0.3"
insta = { version = "1.20", features = ["redactions", "json", "yaml"] }
pretty_assertions = "1.4.0"
rand = { version = "0.8", features = ["small_rng"] }
rand_distr = { version = "0.4" }
serial_test = "0.9"
Expand All @@ -197,7 +198,6 @@ tonic-build = "0.9"

warp = "0.3.3"

pretty_assertions = "1.4.0"

[profile.release]
incremental = true
Expand Down
Loading

0 comments on commit a10c844

Please sign in to comment.