enable self-service ops collections via special case #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a medium-term ... hack, which enables users to read the ops logs and stats of their own tasks. When reading the especially-enumerated collections, we bypass traditional prefix authorization and instead authorize over the `name` partition of the logs or stats collection. Testing: * Verified this enables the new ops view of the entity details page. * Verified that slightly perturbing how build up allowed prefixes causes unauthorized errors to be returned. * Verified that a locally-modified `flowctl` is able to list journals and fragments of task logs, as well as read them, as a regular user of a local stack.
jgraettinger
force-pushed
the
johnny/enable-ops
branch
from
3c15fcb
to
9dccd6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a medium-term ... hack, which enables users to read the ops logs and stats of their own tasks. When reading the especially-enumerated collections, we bypass traditional prefix authorization and instead authorize over the
namepartition of the logs or stats collection.Testing:
flowctlis able to list journals and fragments of task logs, as well as read them, as a regular user of a local stack.