set Path attribute in auth cookie to fix proxy auth in chrome #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Authentication for private ports was broken in Chrome, and perhaps other browsers too. This was caused by the browser rejecting the `__Host-flow_auth` cookie that was attempted to be set by data-plane-gateway. The browser was rejecting the cookie for a seemingly legitimate reason: the spec says it has to be there. I suspect that Firefox was more lax in this case because `Path=/` is semantically equivalent to it not being set at all. In any case, adding the `Path=/` allows authenticated access to private ports to work properly in both Chrome and Firefox.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Authentication for private ports was broken in Chrome, and perhaps other browsers too. This was caused by the browser rejecting the
__Host-flow_authcookie that was attempted to be set by data-plane-gateway. The browser was rejecting the cookie for a seemingly legitimate reason: the spec says it has to be there. I suspect that Firefox was more lax in this case becausePath=/is semantically equivalent to it not being set at all. In any case, adding thePath=/allows authenticated access to private ports to work properly in both Chrome and Firefox.Fixes estuary/connectors#695